Skip to content

Use StaticArrays instead of Vector in RuleNode#43

Draft
THinnerichs wants to merge 6 commits into
masterfrom
perf/static_arrays
Draft

Use StaticArrays instead of Vector in RuleNode#43
THinnerichs wants to merge 6 commits into
masterfrom
perf/static_arrays

Conversation

@THinnerichs
Copy link
Copy Markdown
Member

@THinnerichs THinnerichs commented Mar 24, 2025

StaticArrays are particularly useful whenever the size is already known. As we never CHANGE a RuleNode, but only substitute the children 1. the RuleNode struct can and should be immutable, and 2. the number of children stays constant. This allows us to use SizedArrays (not MVectors, as for mutation the eltype must be isbitstype (i.e. no references, elements immutable, ... ).

References Herb-AI/Herb.jl#148

@THinnerichs THinnerichs self-assigned this Mar 24, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.41%. Comparing base (ebf0001) to head (a47150d).
⚠️ Report is 62 commits behind head on master.

Files with missing lines Patch % Lines
src/rulenode.jl 66.66% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   75.36%   76.41%   +1.04%     
==========================================
  Files           2        2              
  Lines         203      212       +9     
==========================================
+ Hits          153      162       +9     
  Misses         50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants