Repository navigation
test(mongodb): align the in-process _since test with the inclusive filter (#1840) - #1841
Open
angela-helios wants to merge 1 commit into
Open
angela-helios wants to merge 1 commit into
angela-helios wants to merge 1 commit into
Conversation
…lter (#1840) #1796 made the in-process runner's _since inclusive, matching the SQL and native Mongo runners, but mongodb_integration_sof_since_filter still took its cutoff from the first write's own timestamp and expected that write excluded, so main has failed it on every push since. The exclusion cutoff is now one millisecond after the first write, and a new boundary case pins that a write exactly at the cutoff is kept.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1840.
mainhas been red since #1796:Test Rustfailsmongodb_integration_sof_since_filteron every push. That covers #1810, #1822 and #1818, plus PRs branched from them, such as #1839. It is deterministic, not a flake.#1796 (for #1707) made the in-process runner's
_sinceinclusive,>=, to match the SQL runners and the native Mongo runner ($gte). This MongoDB integration test still assumed the old exclusive filter: it took the cutoff fromsince-obs-before's own stored timestamp and expected that resource to be excluded. With an inclusive filter, a resource updated exactly at the cutoff is kept, so the assertion fails every time.Change
The behavior stays as #1796 defined it; only the test changes.
The future-cutoff case is unchanged.
Verification
cargo test -p helios-persistence --features mongodb --test mongodb_tests --no-run).helios-persistence, all targets and features, is clean.Test Rustrun is the check.