Skip to content

Use r-universe workflow for R CMD check and BiocCheck#197

Merged
Bisaloo merged 5 commits into
HelenaLC:mainfrom
Bisaloo:check-release
May 20, 2026
Merged

Use r-universe workflow for R CMD check and BiocCheck#197
Bisaloo merged 5 commits into
HelenaLC:mainfrom
Bisaloo:check-release

Conversation

@Bisaloo
Copy link
Copy Markdown
Collaborator

@Bisaloo Bisaloo commented May 15, 2026

No description provided.

@Artur-man
Copy link
Copy Markdown
Collaborator

Put a BioC check on top ? perhaps for only ubuntu or mac.

      - name: Run BiocCheck
        env:
          DISPLAY: 99.0
        run: |
          BiocCheck::BiocCheck(
              dir('check', 'tar.gz$', full.names = TRUE),
              `quit-with-status` = TRUE,
              `no-check-R-ver` = TRUE,
              `no-check-bioc-help` = TRUE,
              `no-check-remotes` = TRUE
          )
        shell: Rscript {0}

@Bisaloo
Copy link
Copy Markdown
Collaborator Author

Bisaloo commented May 17, 2026

My preference would be to have BiocCheck in a separate workflow. I find it cleaner and it keeps the R CMD check workflow quasi-identical to the upstream in r-lib/actions, thus making updates easier.

Same for pkgdown, etc. These are conceptually distinct tasks.

What do you think?

@HelenaLC
Copy link
Copy Markdown
Owner

I agree. Just another thought: what about the r-universe action? My understanding was that that'll replace all of it soon?

@HelenaLC
Copy link
Copy Markdown
Owner

Speaking of which, how do I find the GitHub pages deployment?

@Bisaloo Bisaloo force-pushed the check-release branch 2 times, most recently from 40198fd to 30f24f9 Compare May 18, 2026 14:34
@Bisaloo
Copy link
Copy Markdown
Collaborator Author

Bisaloo commented May 20, 2026

Good idea! We're now using the r-universe workflow for R CMD check and BiocCheck.

@Bisaloo Bisaloo changed the title Use standard R CMD check workflow Use r-universe workflow for R CMD check and BiocCheck May 20, 2026
@Bisaloo Bisaloo merged commit 7385312 into HelenaLC:main May 20, 2026
10 of 12 checks passed
@Bisaloo Bisaloo deleted the check-release branch May 20, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants