-
-
Notifications
You must be signed in to change notification settings - Fork 146
feat: v3.0.8 #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: v3.0.8 #342
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c9ba066
fix: edit profile UI update
codenameakshay 51b1af9
fix: profile completeness widget redesign
codenameakshay 7e57945
fix: minor UI rework
codenameakshay 885b308
fix: update profile UI barely
codenameakshay 39fd2e8
fix: sentry issues
codenameakshay 09c2b89
chore: fix test
codenameakshay 09272e7
chore: update app version
codenameakshay 5302865
chore: update changelog
codenameakshay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
For google_sign_in v7.2.0, what are the documented meanings of GoogleSignInExceptionCode.canceled vs GoogleSignInExceptionCode.unknownError, and is unknownError guaranteed to be user-initiated cancellation? Also, are "no credential" / "no credentials available" documented cancellation signals?💡 Result:
GoogleSignInExceptionCode.canceled: “The operation was canceled by the user.” [1]GoogleSignInExceptionCode.unknownError: “A catch-all … for implementations that need to return a code that does not have a corresponding known code”, and the exception description should contain details. [1]Is
unknownErrorguaranteed to be user-initiated cancellation?No. It’s explicitly documented as a catch-all for uncategorized errors, not as a cancellation signal. [1]
Are “no credential” / “No credential(s) available” documented cancellation signals?
No. In the Android Credential Manager API,
NoCredentialExceptionmeans no viable credential is available, whileGetCredentialCancellationExceptionis the documented “user intentionally cancels” case. [2]In
google_sign_in_android, the “No credential available: …” message is produced for thenoCredentialfailure type (mapped tounknownErrorin the button flow), not for a cancellation. [3]Also note: even
canceleditself is not guaranteed to be truly user-initiated on Android—google_sign_in_androiddocuments that some configuration errors can surface asGoogleSignInExceptionCode.canceled, and the plugin can’t distinguish those from real user cancellation. [4]Sources
[1]
GoogleSignInExceptionCodeenum docs (google_sign_in v7.2.0) (pub.dev)[2] AndroidX Credential Manager
GetCredentialException/ subclasses docs (developer.android.com)[3]
google_sign_in_androidimplementation mappingnoCredential→ “No credential available …” (chromium.googlesource.com)[4]
google_sign_in_androidtroubleshooting docs about “canceled” sometimes being configuration errors (pub.dev)Citations:
Do not classify
unknownErroror "no credential" messages as user cancellation.Lines 199 and 202-205 misclassify non-cancellation errors as cancellations. Per the
google_sign_inv7.2.0 documentation:GoogleSignInExceptionCode.unknownErroris a catch-all for uncategorized errors, not a cancellation signal.Because this codebase suppresses errors for canceled sign-ins (
session_repository_impl.dart:127-139,onboarding_v2_shell.dart:109-122,settings_screen.dart:394-407,signInPopUp.dart:207-220), misclassifying real failures as cancellation silently swallows error feedback to users.Remove
unknownErrorfrom line 199 and remove the'no credential'and'no credentials available'checks from lines 202-205. Retain onlycanceledand'cancelled'.🤖 Prompt for AI Agents