fix(#674): add configurable timeout to all network requests in SDK client#815
Merged
Haroldwonder merged 2 commits intoJun 7, 2026
Merged
Conversation
…ts in SDK client On mobile networks with poor connectivity, requests to the Soroban RPC server could hang indefinitely. Added a configurable timeout (default 30s) that wraps every network call (getAccount, simulateTransaction, sendTransaction, getTransaction) using Promise.race. - Added timeoutMs option to SwiftRemitClientOptions (default 30s) - Added withTimeout() helper that rejects after the configured duration - Applied timeout to prepareTransaction, submitTransaction, and simulateCall Closes Haroldwonder#674
|
@devSoniia is attempting to deploy a commit to the Harold's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@devSoniia Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #674
submitTransaction()and other methods insdk/src/client.tsmade network calls to the Soroban RPC server without any timeout. On mobile networks with poor connectivity, requests could hang indefinitely.Changes
timeoutMsfield toSwiftRemitClientOptions(default: 30 seconds)withTimeout<T>()helper usingPromise.raceto enforce the timeoutwithTimeout()to all RPC calls inprepareTransaction,submitTransaction, andsimulateCallUsage