Add NPC statblock view mode with PNG download#335
Merged
HarmlessHarm merged 8 commits intodevelopfrom Apr 4, 2026
Merged
Conversation
Collaborator
Author
|
Add eye icon to NPC table and View button to Edit NPC screen that open the statblock in a drawer with PNG download support, reusing the existing Monster component and export functionality. Fixes #333
- Move View button to BasicInfo card header and save section (always visible) - Collapse NPC table action buttons into ellipsis menu with popup proxy - Add header-right slot to BasicInfo.vue for parent-injected header actions
- Move View button to save section left of Back (no icon) - View button in BasicInfo header stays right-aligned via slot
The popup proxy was shown on all screen sizes after the statblock view feature was added. Now inline buttons (View, Edit, Export, Delete) are shown on screens wider than 575px, and the ellipsis + popup proxy only appears on smaller screens.
monster.saving_throws can be undefined for NPCs that haven't set any saving throw proficiencies. Use optional chaining so it safely returns undefined (falsy) instead of throwing.
HarmlessHarm
force-pushed
the
feat/issue-333__view-npc-statblock-download-png
branch
from
3b4b4b0 to
b68d196
Compare
Renders ExportUserContent as a transparent span inside q-item so Quasar's clickable/close-popup behavior works correctly without relying on a custom tag override. Removes unused .export-menu-item style.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #333
Test plan