Award XP outside of encounters#334
Merged
HarmlessHarm merged 5 commits intodevelopfrom Mar 21, 2026
Merged
Conversation
Split the actions array display into regular and bonus action sections by filtering on an optional timing field. Bonus actions share the existing actions[] array; timing: "bonus_action" routes items to a separate UI section with its own header, add button, and draggable list. - hk-npc-schema.json: allow timing field on action items - npcs/Actions.vue: 5-entry config, filtered draggables, timing dropdown - CardActions.vue: split entity.actions into two labeled sections - Monster.vue: same split for compendium display
Enable the "Award XP" button on the campaign Players view by converting isXpAdvancement from a hardcoded false to a computed property that checks campaign.advancement !== "milestone". Also fix calcColspan referencing undefined this.settings instead of this.userSettings.general, and use optional chaining throughout both computed properties. Refs #332
Revert CardActions.vue, Monster.vue, Actions.vue, and hk-npc-schema.json to develop state — these changes belong to the NPC bonus actions feature, not to issue #332 (award XP outside encounters).
Collaborator
Author
|
Review comments:
|
HarmlessHarm
added
feature
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isXpAdvancementfrom a hardcodedfalsedata property to a computed property that checkscampaign.advancement !== "milestone"calcColspanthat referenced undefinedthis.settingsinstead ofthis.userSettings.generaluserSettings.generalchecks in bothtemplateColumnsandcalcColspanFixes #332
Test plan
userSettings.generalis undefined