Update companies.yml

[Dhizi]

AEGIS Faction removal. Cleared by me, and the one member on it.

About the PR

AEGIS no longer exists in this server.

Why / Balance

To remove any final investments to the server.

Technical details

9 lines of yml. removed that held the AEGIS faction info.

Breaking changes

AEGIS faction removal from Hardlight Server.

[NatusExVacuo]

The main issue that I could see here is that Aegis as a company was not disabled and so was selectable by anyone. The best way to test that it would not be broken is to try and load a character with this faction saved, with the faction in the game removed, and see if it defaults to no company or if it crashes the client.

[NatusExVacuo]

@Dhizi Have you tested this in a local instance to make sure it doesn't crash anything?

[Dhizi]

@Dhizi Have you tested this in a local instance to make sure it doesn't crash anything?

I can go ahead and do that, sure.

[Dhizi]

@Dhizi Have you tested this in a local instance to make sure it doesn't crash anything?

It defaults to none automatically. No crash, my ships load perfectly fine, no errors thrown by it.

[NatusExVacuo]

@AutumnalModding Doesn't seem to be any issues with this PR. I don't see any harm in someone wanting to remove a faction from a server if the people who created that faction no longer want to be a part of said server. Should not break anything.

[Dhizi]

@AutumnalModding Doesn't seem to be any issues with this PR. I don't see any harm in someone wanting to remove a faction from a server if the people who created that faction no longer want to be a part of said server. Should not break anything.

It's because they're being spiteful. I have them blocked as to not tolerate it. They will likely continue to try to impede any efforts to move this forward because I took their freedom to harass me and others away.

[NotLivyathan]

Previous PR was closed by Autumnal with no input from administration, I assume simply because they could and want to feel like they have some semblance of power. It was explained and argued (by them) as a spite PR, when in reality, it's cleaning bloat. If something was made by someone that is no longer part of the server, and no one else uses it, meaning it is then irrelevant, it is bloat.

It is also a well-known fact at this point that removing a faction after the fact does not cause issues with shuttle loading.

Autumnal's permissions on this repo need to be re-evaluated, because they consistently either abuse those permissions or contemplate abusing them.

[NatusExVacuo]

It's because they're being spiteful. I have them blocked as to not tolerate it. They will likely continue to try to impede any efforts to move this forward because I took their freedom to harass me and others away.

That sounds like something wholy unrelated to code. I understand you are upset at them, but it's inappropriate for the github to be a shouting match between you and people who are upset at you.

[Dhizi]

Previous PR was closed by Autumnal with no input from administration, I assume simply because they could and want to feel like they have some semblance of power. It was explained and argued (by them) as a spite PR, when in reality, it's cleaning bloat. If something was made by someone that is no longer part of the server, and no one else uses it, meaning it is then irrelevant, it is bloat.

Autumnal's permissions on this repo need to be re-evaluated, because they consistently either abuse those permissions or contemplate abusing them.

I offered them the means and willingness to help out, and they took it as a threat. So much so they thought that reporting me for 'harassment' would change my tune when my tune was very plainly -- Allow me to remove my work and not hassle yourself, or do it yourself.

Children will be children.

[NatusExVacuo]

Previous PR was closed by Autumnal with no input from administration, I assume simply because they could and want to feel like they have some semblance of power. It was explained and argued (by them) as a spite PR, when in reality, it's cleaning bloat. If something was made by someone that is no longer part of the server, and no one else uses it, meaning it is then irrelevant, it is bloat.

Autumnal's permissions on this repo need to be re-evaluated, because they consistently either abuse those permissions or contemplate abusing them.

If this is happening a lot, I recommend messaging the relevant administration. Having this shout match on the github is inappropriate, but I do agree it's not very good that anyone can close a PR for any reason.

[Dhizi]

It's because they're being spiteful. I have them blocked as to not tolerate it. They will likely continue to try to impede any efforts to move this forward because I took their freedom to harass me and others away.

That sounds like something wholy unrelated to code. I understand you are upset at them, but it's inappropriate for the github to be a shouting match between you and people who are upset at you.

It sadly was not this until they stepped in to assert power over something meaningless to them, but meaningful to me. As well as their justification was either a lie or incorrect -- as I had no problems spawning the ship I owned, as was justification for their denial of the PR.

I'm not upset at them. I plainly wish to move forward, and for some reason, they are choosing to throw obstacles in my way to doing so.

The code removal causes no errors, no crashes, and defaults all profiles to no-company value. It's of no-threat to be PR'd.

[Dhizi]

Previous PR was closed by Autumnal with no input from administration, I assume simply because they could and want to feel like they have some semblance of power. It was explained and argued (by them) as a spite PR, when in reality, it's cleaning bloat. If something was made by someone that is no longer part of the server, and no one else uses it, meaning it is then irrelevant, it is bloat.
Autumnal's permissions on this repo need to be re-evaluated, because they consistently either abuse those permissions or contemplate abusing them.

If this is happening a lot, I recommend messaging the relevant administration. Having this shout match on the github is inappropriate, but I do agree it's not very good that anyone can close a PR for any reason.

It does happen a lot. Blocking was the most considerate means to move us forward. Now once the tag for the PR to move forward is removed, we can go back to our lives, and go our separate ways as mature adults.

[NotLivyathan]

I cleaned up some of your tags, as they were inappropriately applied.

[Dhizi]

And...Very pointedly as proven -- Autumnal is not proving me wrong in my accusation, and continuing to abuse their power, as i'm watching them repeatedly re-apply tags that do not belong to this PR out of petty spite, which is making us all linger here for no reason other than them crashing out.

Autumnal. Walk away. This is not appropriate.

Let me leave this place already. We have better things to do with our lives.

[NotLivyathan]

It's a simple YAML change to remove an unused faction. Despite the inexcusable toxicity coming from another Collaborator, there is no reason not to merge this PR.

[okdamsam]

I've tested on local, it does not break the ship nor the character. Unmatched factions in the CompanyComponent are displayed as simple text.

On any complaint of spite... there are 28 factions coded, and a majority of them are unused. It was recently discussed that these should be cleaned up. So either in this PR, or a future cleaning PR, the faction would removed regardless.