Brussels | ITP-2025-1 | Daniela Fajardo | Sprint 3 | Coursework/sprint 3 2 practice tdd #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaBora
reviewed
Jan 7, 2026
| if (numerator < denominator) { | ||
| return true; | ||
| } | ||
| if (numerator > denominator) { |
There was a problem hiding this comment.
those ifs are unnecessary, because after the first if fails, its obvious that it is either equal or bigger.
There was a problem hiding this comment.
only return false; was enough. But not a big issue
MustafaBora
reviewed
Jan 7, 2026
| const numRank = Number(rank); //to convert any numeric string in an actual numeric value. Example: "5" !== 5 | ||
| if (rank == "A") { | ||
| return 11; | ||
| } else if (rank === "J" || rank === "Q" || rank === "K") { |
MustafaBora
requested changes
Jan 7, 2026
| // Given a card with an invalid rank (neither a number nor a recognized face card), | ||
| // When the function is called with such a card, | ||
| // Then it should throw an error indicating "Invalid card rank." | ||
| const invalidCard1 = getCardValue("10Q"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Exercise solutions sprint 3 practice tdd