ITP-2025-1|Elena Vasileia|Week 6|Module-Structuring-and-Testing-Data/Sprint-3/ implement and rewrite & practice TDD #37
+224
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented angle type identification for acute, obtuse, straight, and reflex angles. Completed the code. Tests run normally.
Updated isProperFraction function to use absolute values for proper fraction checks and added assertions for various test cases.
Refactor getCardValue function to handle card ranks and add tests for various cases including face cards and invalid cards.
…e are of my original thought)
…running the tests
…xed it back to .toEqual
EL1VAS
changed the title
MustafaBora
reviewed
Jan 7, 2026
| // write one test at a time, and make it pass, build your solution up methodically | ||
| // just make one change at a time -- don't rush -- programmers are deep and careful thinkers | ||
| function getCardValue(card) { | ||
| const rank = card.slice(0, -1); // Extract rank by removing the last character (emoji) |
There was a problem hiding this comment.
slice(0, -1) is great because it also covers card 10
MustafaBora
approved these changes
Jan 7, 2026
MustafaBora
left a comment
MustafaBora
left a comment
There was a problem hiding this comment.
As an answer to your comment, expect(getOrdinalNumber(1)).toBe("1st"); is more standard as far as I learned. There is more to explore on jest for sure. But this is a nice warmup for testing basics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the united repository, I realized when it was too late
Self checklist
Changelist
I completed and created new tests and then made my functions. My VScode has a suggestion function that helped me further (and which I don't know how I activated it neither how to deactivated it :)). Some methods like .toThrow I explored further but decided to stick with the .toEqual for now.
I have to admit that the testing part of coding (although I fully understand it's neccessity) it's not my favorite :)
Questions
Ask any questions you have for your reviewer.