Fix GPU memory leak by disposing intermediate geometries after GLTF merge#790
Open
Yashika0724 wants to merge 1 commit intoHSF:mainfrom
Open
Fix GPU memory leak by disposing intermediate geometries after GLTF merge#790Yashika0724 wants to merge 1 commit intoHSF:mainfrom
Yashika0724 wants to merge 1 commit intoHSF:mainfrom
Conversation
Signed-off-by: Yashika0724 <[email protected]> Signed-off-by: Yashika <[email protected]>
Author
|
Hi @EdwardMoyse , This fixes a small GPU memory leak during GLTF geometry merging by disposing intermediate geometries, following an existing pattern in the codebase. Happy to adjust if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a GPU memory leak in the GLTF loading path where intermediate geometries created during BufferGeometryUtils.mergeGeometries() were not being disposed after the merged mesh was created.
In loadGLTFGeometryInternal, individual mesh geometries are cloned and transformed before being merged into a single geometry per material. While the merged geometry is used for rendering, the intermediate cloned geometries remained allocated in GPU memory and were never released.
Since Three.js requires explicit disposal of GPU-backed resources, repeated geometry loads (or reloads) in long-running sessions could lead to steadily increasing GPU memory usage and eventually WebGL context loss or browser crashes.
Fix
After creating and adding the merged mesh to the scene, this change explicitly disposes all intermediate geometries used in the merge step. This follows the same disposal pattern already used in phoenix-objects.ts, keeping behavior consistent across geometry loading paths.
Impact
Testing
Scope