Skip to content

Conversation

@jjokella
Copy link
Contributor

@jjokella jjokella commented Oct 8, 2025

Minor build script fixes found by AI.

Feel free to adjust, from my review they are sensible.

@jjokella jjokella requested a review from s-poll October 8, 2025 13:49
@jjokella
Copy link
Contributor Author

jjokella commented Oct 8, 2025

Not sure, why this failure happens that both parflow and parflowGPU are set: https://github.com/HPSCTerrSys/TSMP2/actions/runs/18348125258/job/52260255407

Trying to reproduce it on my laptop, everything was fine.

Hypothesis: parflow has a default value of y as an artefact somehow that needs to be cleaned up?

@jjokella jjokella merged commit 5cf4839 into master Oct 9, 2025
5 checks passed
@jjokella jjokella deleted the dev-build-script branch October 9, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants