Prevent recursion crash on NaN image data - #2045
Merged
Merged
Conversation
Images that are fully NaN (e.g. dark subtraction with a NaN dark file) made the color map bounds NaN, and NaN spin box values recurse infinitely since NaN != NaN re-emits valueChanged on every clamp. Guard the spin boxes, fall back to a finite range, and keep one bad detector from turning the global scaling minimum into NaN. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
psavery
force-pushed
the
fix-nan-colormap-recursion
branch
from
July 8, 2026 04:49
b70e69c to
19c3ffd
Compare
saransh13
approved these changes
Aug 14, 2026
saransh13
left a comment
saransh13
left a comment
Member
There was a problem hiding this comment.
I've lost the stack trace and the recipe to reproduce this so unable to test this. I'm sure that the np.nan and np.inf checks won't break anything so approving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Images that are fully NaN (e.g. dark subtraction with a NaN dark file) made the color map bounds NaN, and NaN spin box values recurse infinitely since NaN != NaN re-emits valueChanged on every clamp. Guard the spin boxes, fall back to a finite range, and keep one bad detector from turning the global scaling minimum into NaN.