some extra operations were being performed. The results should be identical - #961
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #961 +/- ##
=======================================
Coverage 73.57% 73.58%
=======================================
Files 148 148
Lines 22943 22941 -2
=======================================
- Hits 16881 16880 -1
+ Misses 6062 6061 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
psavery
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An extra quantity was computed for determining the x-coordinate. However, that is not needed. The extra operation just results in dot product of two orthogonal vectors, which evaluates to zero. Removing that extra step.