-
-
Notifications
You must be signed in to change notification settings - Fork 22
fixed LZ4 plugin #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fixed LZ4 plugin #202
Conversation
|
I would like to get a CI running before submitting this PR (see #201). |
|
OK, approve my workflow runs and we'll see how the CI likes these changes... |
|
I can verify that after this change, the lz4 plugin seems to write valid data, but is broken before this. |
|
@bmaranville Can you explain more in what way was this plugin broken before? And when was before? Until the changes in this PR? |
|
Sorry - I was mistaken. The fix seems to be somewhere between version |
|
Thanks for checking. |
Fixes for the LZ4 plugin. Fixes #200
Important
Fix and optimize LZ4 plugin by removing
statickeyword, initializingblockSize, usingLZ4_compress_fast, and commenting out debug prints inH5Z_filter_lz4.statickeyword fromH5Z_filter_lz4declaration and definition inH5Zlz4.c.blockSizetoDEFAULT_BLOCK_SIZEin forward filter path.LZ4_compress_fastinstead ofLZ4_compress_defaultinH5Z_filter_lz4.printfstatements inH5Z_filter_lz4for decompression size mismatch and block size information.This description was created by
for bcb40e0. You can customize this summary. It will automatically update as commits are pushed.