Make Location encoding algorithm consistent with other implementations.#204
Merged
Conversation
Member
Author
No, this is based on the same faulty implementation I referenced for the libHSPlasma fix... This needs to be updated too. EDIT: Actually, the original code produced correct results; this whole PR is based on my faulty read of the Plasma code :(. I'll just update it to be consistent with the change to libHSPlasma, and keep the Catch update. |
772a95a to
5927199
Compare
…asma and H-uru/Plasma).
5927199 to
b0fb0c8
Compare
dpogue
approved these changes
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although DS doesn't actually encode any locations with negative prefixes anywhere outside of the tests, the computation was incorrect. This now matches the encodings generated by plAgeDescription::CalcPageLocation in H-uru/Plasma.
Yes, I'm aware that libhsplasma's computation is even more broken than this... I'll probably address that one next.