docs: document v1.2 breaking changes in the upgrade guide - #2727
Merged
Conversation
4 tasks
Deploying greptime-docs with
|
| Latest commit: |
1f052aa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eb2e7b48.greptime-docs.pages.dev |
| Branch Preview URL: | https://copilot-document-v1-2-breaki-j02l.greptime-docs.pages.dev |
Copilot
AI
changed the title
[WIP] Document v1.2 breaking changes in the upgrade guide
Document v1.2 upgrade breaking changes
Aug 10, 2026
4 tasks
fengjiachun
changed the title
Contributor
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb4d3ee850
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: fengjiachun <3860496+fengjiachun@users.noreply.github.com>
Verified each item against the upstream PRs and fixed the inaccurate ones: - holt_winters was a backward-compatibility alias, not a removed function. It maps to double_exponential_smoothing, which predates v1.2, so the migration is a rename rather than a rewrite (GreptimeTeam/greptimedb#8457). - fill/fill_left/fill_right are binary-operator modifiers that only became parseable with the promql-parser 0.10.0 bump in the same release, so no query that worked before v1.2 is affected. Also noted that this is unrelated to the SQL RANGE ... FILL clause. - Integer narrowing covers int8/int16/int32/uint8/uint16/uint32 plus cross-sign conversions into the 64-bit types (GreptimeTeam/greptimedb#8589). - A config that still sets sparse_primary_key_encoding loads without error; the key is ignored rather than rejected (GreptimeTeam/greptimedb#8470). - The option lives under [region_engine.metric] within a [[region_engine]] entry, not in a [metric_engine] block. Corrected both the new cleanup instruction and the pre-existing example in the v0.17-to-v1.0 section. Also dropped the redundant heading level so the items sit at the same depth as the other per-version sections, replaced the beta.1 label with v1.2, added the cross-links the Chinese page was missing, and narrowed the checklist grep hints to fill( so they do not match every SQL RANGE ... FILL. The configuration reference cleanup is left to #2728, which landed on main with the same conclusion.
fengjiachun
force-pushed
the
copilot/document-v1-2-breaking-changes-again
branch
from
August 11, 2026 04:05
fb4d3ee to
1f052aa
Compare
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fengjiachun
marked this pull request as ready for review
August 11, 2026 07:31
WenyXu
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The v1.2 upgrade guide was missing several compatibility-impacting changes from v1.2.0-beta.1. This update adds the missing migration guidance and concrete upgrade checks to both Nightly and v1.2 docs in English and Chinese.
Upgrade path coverage
Breaking-change migration guidance
holt_winters().fill,fill_left, andfill_rightusages until outer-join semantics are supported.on_failureinstead of wrapping; float-to-integer behavior remains unchanged.sparse_primary_key_encoding/experimental_sparse_primary_key_encodingas upgrade cleanup.Practical checks
COPY/ external-table migrationScope
Verification
pnpm buildDOC_LANG=zh pnpm buildDOC_LANG=en pnpm check:linksDOC_LANG=zh pnpm check:linksgit diff --checkChecklist