-
Notifications
You must be signed in to change notification settings - Fork 0
fix: pin typing extensions #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request updates 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
d0b0738 to
a334c7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@setup.cfg`:
- Line 33: The dependency entry typing_extensions>=4.14.1 in setup.cfg is unused
or incorrectly pinned; either remove that line if no code imports
typing_extensions, or add a comment above it explaining why it's required (e.g.,
backport types for older Python or specific features used); if you intended to
pin the version change the specifier from >=4.14.1 to ==4.14.1 for an exact pin
or to ~=4.14.1 for a compatible pin. Ensure you modify the setup.cfg entry
"typing_extensions>=4.14.1" accordingly and run a quick grep for
typing_extensions imports to confirm removal is safe.
| python-on-whales | ||
| watchdog | ||
| GitPython | ||
| typing_extensions>=4.14.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for typing_extensions imports in the codebase
rg -n "from typing_extensions import|import typing_extensions" --type=pyRepository: Greenroom-Robotics/platform_cli
Length of output: 57
🏁 Script executed:
#!/bin/bash
# Check PyPI for version validity and other typing_extensions info
echo "Checking typing_extensions on PyPI..."
curl -s https://pypi.org/pypi/typing_extensions/json | jq -r '.info.version, .releases | keys[]' | head -20Repository: Greenroom-Robotics/platform_cli
Length of output: 185
🏁 Script executed:
#!/bin/bash
# Better check for typing_extensions releases
curl -s https://pypi.org/pypi/typing_extensions/json | jq -r '.info.version as $latest | .releases | keys[] | select(startswith("4.14"))' | sort -VRepository: Greenroom-Robotics/platform_cli
Length of output: 98
🏁 Script executed:
#!/bin/bash
# Check if typing_extensions might be a transitive dependency
rg -n "typing.extensions|typing_extensions" --type=pyRepository: Greenroom-Robotics/platform_cli
Length of output: 57
Remove or document unused dependency.
The typing_extensions>=4.14.1 dependency is not imported or used anywhere in the codebase. Either remove it if it's not needed, or add a comment explaining its purpose. Additionally, if "pin" was the intent, >=4.14.1 is a minimum version constraint, not a pin. Consider using ==4.14.1 for an exact pin or ~=4.14.1 for compatible releases.
🤖 Prompt for AI Agents
In `@setup.cfg` at line 33, The dependency entry typing_extensions>=4.14.1 in
setup.cfg is unused or incorrectly pinned; either remove that line if no code
imports typing_extensions, or add a comment above it explaining why it's
required (e.g., backport types for older Python or specific features used); if
you intended to pin the version change the specifier from >=4.14.1 to ==4.14.1
for an exact pin or to ~=4.14.1 for a compatible pin. Ensure you modify the
setup.cfg entry "typing_extensions>=4.14.1" accordingly and run a quick grep for
typing_extensions imports to confirm removal is safe.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.