chore: pin vllm-rs ref and report decode stats#461
Merged
Conversation
gufengc
changed the title
gufengc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.shfor buildingvllm-rstov0.22.0.vllm-rs.versionsidecar next to the installed binary after a successful build.vllm-rswhen an existing binary is missing the sidecar or the sidecar does not match the requestedVLLM_REF; skip only when the recorded version matches.Why
The installer previously skipped rebuilding whenever
.venv/bin/vllm-rsalready existed, regardless of which vLLM ref it came from. That made it easy to keep using an older or different binary after changingVLLM_REF.Validation
bash -n install.sh./install.sh --extras macto rebuildvllm-rsfromv0.22.0.venv/bin/vllm-rs --help.venv/bin/vllm-rs frontend --help.venv/bin/python -m pytest tests/test_vllm_rust_frontend.py tests/test_engine_core_protocol.py tests/test_backend_request_handler.py.venv/bin/pre-commit run --all-files.venv/bin/pytest(125 passed, 5 skipped)