-
Notifications
You must be signed in to change notification settings - Fork 51
chore: bump git-sync to v4.4.2-gke.10 #1991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This includes CVE fixes
Summary of ChangesHello @Camila-B, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine but critical dependency update for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the git-sync version to v4.4.2-gke.10 in the Makefile. The change is intended to incorporate security fixes, as mentioned in the description. The version bump is applied correctly. I have one suggestion to improve the consistency of version variable definitions, which could be addressed in a future refactoring.
| COSIGN := $(BIN_DIR)/cosign | ||
|
|
||
| GIT_SYNC_VERSION := v4.4.2-gke.9__linux_amd64 | ||
| GIT_SYNC_VERSION := v4.4.2-gke.10__linux_amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GIT_SYNC_VERSION variable includes the platform suffix __linux_amd64 directly in its value. This is inconsistent with other version variables in this file, like HELM_VERSION (line 84) and KUSTOMIZE_VERSION (line 80), where platform-specific parts are handled separately. To improve consistency and maintainability, consider refactoring this in the future. For example:
GIT_SYNC_BASE_VERSION := v4.4.2-gke.10
GIT_SYNC_VERSION := $(GIT_SYNC_BASE_VERSION)__linux_amd64This would align the approach with other version definitions and make future updates clearer.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cowsking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
This includes CVE fixes
This includes CVE fixes