Skip to content

Reporting info and debug logs other than Errors #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Reporting info and debug logs other than Errors #88

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed70841
Reporting info and debug logs other than Errors
indrajeet0510 Apr 21, 2021
5c4acd2
Fixing issues with PR
indrajeet0510 Apr 21, 2021
1204969
Update stackdriver-errors.js
indrajeet0510 Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion stackdriver-errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,10 @@ StackdriverErrorReporter.prototype.start = function(config) {
this.projectId = config.projectId;
this.targetUrl = config.targetUrl;
this.context = config.context || {};
this.serviceContext = {service: config.service || 'web'};
this.serviceContext = {service: config.service || 'web',
resourceType: config.resourceType || 'reported_errors',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are also adding resourceType in context.
I am supportive, but I recommend sending a different PR for this.

severity: 'ERROR' || config.severity
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you talk more about why you think severity should be stored in the config?

I would expect instead the severity to be provided every time an error is reported.

};
if (config.version) {
this.serviceContext.version = config.version;
}
Expand Down