Skip to content

remove prefered=False for version definitions - #1736

Merged
dapomeroy merged 1 commit into
GoogleCloudPlatform:developfrom
rfbgo:preffalse
Aug 20, 2026
Merged

remove prefered=False for version definitions#1736
dapomeroy merged 1 commit into
GoogleCloudPlatform:developfrom
rfbgo:preffalse

Conversation

@rfbgo

@rfbgo rfbgo commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@rfbgo
rfbgo requested a review from dapomeroy August 20, 2026 20:15

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the redundant preferred=False argument from version(...) declarations across various application, modifier, package manager, and workflow manager files, simplifying the code. There are no review comments, so I have no feedback to provide.

@ramble-pr-bot

ramble-pr-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: ebb82a3

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.0352 2.0909 (185471f) 2.0958
test_large_template_expansion passed 1.1810 1.1892 (185471f) 1.3997
test_many_experiments passed 23.0655 23.2019 (185471f) 24.5554
test_many_objects_defaults passed 12.8160 13.1219 (185471f) 13.6278
test_matrix_filter_perf passed 1.0618 1.0546 (185471f) 1.1271

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.03%. Comparing base (185471f) to head (ebb82a3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1736   +/-   ##
========================================
  Coverage    94.02%   94.03%           
========================================
  Files          367      367           
  Lines        36933    36933           
========================================
+ Hits         34728    34729    +1     
+ Misses        2205     2204    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dapomeroy
dapomeroy merged commit a5553af into GoogleCloudPlatform:develop Aug 20, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants