Do not exit early in repo listing - #1734
Conversation
Right now when it sees a particular object type has 0 repo, it returns. This is usually OK since we have built-in repos for each object type, but can be problematic when querying with specific scope (`--scope`). Incidentally, remove an unused chunk of comment.
There was a problem hiding this comment.
Code Review
This pull request fixes an issue in the repo list command where the command would prematurely return instead of continuing the loop when a repository type had no repositories in scope. This allows other repository types to be listed correctly. Additionally, dead commented-out code for is_virtual was removed from repository.py, and a new test was added to verify listing repositories when no applications are in scope. No review comments were provided, so there is no feedback to address.
Ramble Performance Test MetricsResults produced with commit: b9d9de4
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1734 +/- ##
========================================
Coverage 94.02% 94.03%
========================================
Files 367 367
Lines 36933 36939 +6
========================================
+ Hits 34728 34735 +7
+ Misses 2205 2204 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
90bcea8
into
GoogleCloudPlatform:develop
Right now when it sees a particular object type has 0 repo, it returns. This is usually OK since we have built-in repos for each object type, but can be problematic when querying with specific scope (
--scope).Incidentally, remove an unused chunk of comment.