Skip to content

Do not exit early in repo listing - #1734

Merged
douglasjacobsen merged 1 commit into
GoogleCloudPlatform:developfrom
linsword13:repo-fix
Aug 21, 2026
Merged

Do not exit early in repo listing#1734
douglasjacobsen merged 1 commit into
GoogleCloudPlatform:developfrom
linsword13:repo-fix

Conversation

@linsword13

Copy link
Copy Markdown
Member

Right now when it sees a particular object type has 0 repo, it returns. This is usually OK since we have built-in repos for each object type, but can be problematic when querying with specific scope (--scope).

Incidentally, remove an unused chunk of comment.

Right now when it sees a particular object type has 0 repo, it returns. This is usually OK since we have built-in repos for each object type, but can be problematic when querying with specific scope (`--scope`).

Incidentally, remove an unused chunk of comment.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue in the repo list command where the command would prematurely return instead of continuing the loop when a repository type had no repositories in scope. This allows other repository types to be listed correctly. Additionally, dead commented-out code for is_virtual was removed from repository.py, and a new test was added to verify listing repositories when no applications are in scope. No review comments were provided, so there is no feedback to address.

@ramble-pr-bot

ramble-pr-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: b9d9de4

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.0649 2.0909 (185471f) 2.0958
test_large_template_expansion passed 1.2067 1.1892 (185471f) 1.3997
test_many_experiments passed 24.5007 23.2019 (185471f) 24.5554
test_many_objects_defaults passed 13.4725 13.1219 (185471f) 13.6278
test_matrix_filter_perf passed 1.0769 1.0546 (185471f) 1.1271

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.03%. Comparing base (185471f) to head (b9d9de4).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1734   +/-   ##
========================================
  Coverage    94.02%   94.03%           
========================================
  Files          367      367           
  Lines        36933    36939    +6     
========================================
+ Hits         34728    34735    +7     
+ Misses        2205     2204    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@douglasjacobsen
douglasjacobsen merged commit 90bcea8 into GoogleCloudPlatform:develop Aug 21, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants