Skip to content

promote simple tests to prefer ramble workspace manage - #1732

Merged
douglasjacobsen merged 1 commit into
GoogleCloudPlatform:developfrom
rfbgo:prefer_manage
Aug 21, 2026
Merged

promote simple tests to prefer ramble workspace manage#1732
douglasjacobsen merged 1 commit into
GoogleCloudPlatform:developfrom
rfbgo:prefer_manage

Conversation

@rfbgo

@rfbgo rfbgo commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@rfbgo
rfbgo requested a review from douglasjacobsen August 20, 2026 13:33

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors various unit and end-to-end tests to align with updated guidelines in AGENTS.md. It replaces manual YAML configuration writing and the deprecated generate-config command with the workspace manage experiments subcommand, and updates deprecated -p flags to -V package_manager=. The feedback suggests combining redundant workspace command invocations in test_workspace_info_with_where_filter into a single call with multiple --wf options to simplify the test code and improve execution efficiency.

Comment thread lib/ramble/ramble/test/cmd/workspace.py
@ramble-pr-bot

ramble-pr-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: 093f830

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.0829 2.0792 (68681d4) 2.0969
test_large_template_expansion passed 1.2125 1.1981 (68681d4) 1.5081
test_many_experiments passed 24.8078 24.4462 (68681d4) 25.0302
test_many_objects_defaults passed 14.3726 13.1446 (68681d4) 13.9296
test_matrix_filter_perf passed 1.1366 1.0867 (68681d4) 1.1523

@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.01%. Comparing base (68681d4) to head (093f830).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1732      +/-   ##
===========================================
- Coverage    94.01%   94.01%   -0.01%     
===========================================
  Files          367      367              
  Lines        36886    36884       -2     
===========================================
- Hits         34679    34676       -3     
- Misses        2207     2208       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rfbgo rfbgo changed the title promote simple tests to prefer promote simple tests to prefer ramble workspace manage Aug 20, 2026
@douglasjacobsen
douglasjacobsen merged commit 1deb0e5 into GoogleCloudPlatform:develop Aug 21, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants