allow parents to be queried by --where "'{experiment_status}' == - #1729
Conversation
--where "'{experiment_status}' == FAILED--where "'{experiment_status}' ==
There was a problem hiding this comment.
Code Review
This pull request refactors how repeat experiment statuses are calculated and handled in Ramble. It introduces helper methods to retrieve repeat child namespaces and instances, and to calculate the overall status of a repeat base experiment based on its children (supporting both strict and loose success modes). Additionally, it ensures that repeat base statuses are read during ingestion and filtering, clears the filter cache upon pipeline completion, and adds comprehensive tests. A review comment points out a potential bug where slicing could fail if ".chain" is not found in the experiment name, offering a robust code suggestion to handle this case.
Ramble Performance Test MetricsResults produced with commit: 10b66c3
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1729 +/- ##
===========================================
+ Coverage 93.94% 93.96% +0.01%
===========================================
Files 367 367
Lines 36605 36709 +104
===========================================
+ Hits 34389 34492 +103
- Misses 2216 2217 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
douglasjacobsen
left a comment
There was a problem hiding this comment.
Thanks, this is awesome. I added two small comments, but otherwise LGTM.
1099484
into
GoogleCloudPlatform:develop
hoist parent status calculation to allow parents to be queried by
--where "'{experiment_status}' == FAILED