Skip to content

allow parents to be queried by --where "'{experiment_status}' == - #1729

Merged
douglasjacobsen merged 4 commits into
GoogleCloudPlatform:developfrom
rfbgo:parent
Aug 21, 2026
Merged

allow parents to be queried by --where "'{experiment_status}' ==#1729
douglasjacobsen merged 4 commits into
GoogleCloudPlatform:developfrom
rfbgo:parent

Conversation

@rfbgo

@rfbgo rfbgo commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

hoist parent status calculation to allow parents to be queried by --where "'{experiment_status}' == FAILED

@rfbgo
rfbgo marked this pull request as draft August 18, 2026 16:54
@rfbgo rfbgo changed the title allow parents to be queried by --where "'{experiment_status}' == FAILED allow parents to be queried by --where "'{experiment_status}' == Aug 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors how repeat experiment statuses are calculated and handled in Ramble. It introduces helper methods to retrieve repeat child namespaces and instances, and to calculate the overall status of a repeat base experiment based on its children (supporting both strict and loose success modes). Additionally, it ensures that repeat base statuses are read during ingestion and filtering, clears the filter cache upon pipeline completion, and adds comprehensive tests. A review comment points out a potential bug where slicing could fail if ".chain" is not found in the experiment name, offering a robust code suggestion to handle this case.

Comment thread var/ramble/repos/builtin/base_classes/application-base/base_class.py Outdated
@ramble-pr-bot

ramble-pr-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

Ramble Performance Test Metrics

Results produced with commit: 10b66c3

Test Name Outcome Duration (s) Most Recent Run (s) Last 5 Avg (s)
test_analyze_large_file passed 2.1249 2.0909 (185471f) 2.0958
test_large_template_expansion passed 1.7446 1.1892 (185471f) 1.3997
test_many_experiments passed 26.7794 23.2019 (185471f) 24.5554
test_many_objects_defaults passed 15.5685 13.1219 (185471f) 13.6278
test_matrix_filter_perf passed 1.3332 1.0546 (185471f) 1.1271

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.77124% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.96%. Comparing base (8c2f07e) to head (10b66c3).
⚠️ Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...uiltin/base_classes/application-base/base_class.py 86.66% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1729      +/-   ##
===========================================
+ Coverage    93.94%   93.96%   +0.01%     
===========================================
  Files          367      367              
  Lines        36605    36709     +104     
===========================================
+ Hits         34389    34492     +103     
- Misses        2216     2217       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

rfbgo and others added 2 commits August 18, 2026 11:44
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@rfbgo
rfbgo marked this pull request as ready for review August 18, 2026 18:12

@douglasjacobsen douglasjacobsen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is awesome. I added two small comments, but otherwise LGTM.

Comment thread lib/ramble/ramble/test/success_criteria_functionality/repeat_success_strict.py Outdated
Comment thread lib/ramble/ramble/test/success_criteria_functionality/repeat_success_strict.py Outdated
@douglasjacobsen
douglasjacobsen merged commit 1099484 into GoogleCloudPlatform:develop Aug 21, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants