Make slurm workflow manager call execute_experiment#1589
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Slurm workflow manager template to source an execute_experiment script instead of running a generic command, and updates the corresponding tests to verify the generation and contents of this script. The review feedback suggests quoting the {execute_experiment} path in the template to prevent word splitting, and explicitly specifying encoding="utf-8" when opening files in the test suite to ensure cross-platform consistency.
Ramble Performance Test MetricsResults produced with commit: 5605f32
|
…ent_sbatch.tpl Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1589 +/- ##
========================================
Coverage 92.90% 92.90%
========================================
Files 340 340
Lines 32580 32584 +4
========================================
+ Hits 30269 30273 +4
Misses 2311 2311 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| {workflow_hostfile_cmd} | ||
|
|
||
| {command} | ||
| . "{execute_experiment}" |
There was a problem hiding this comment.
This is a great idea!
One thing I wonder, is if (say Slurm) user has expectations that custom sbatch headers they added into execute_experiment template should work, and maybe surprised that they don't?
There was a problem hiding this comment.
Yea great call out, this is definitely a very real and valid concern. Do you think it is sufficient to detect it and warn the user? or is it so concerning that we should not pursue this approach?
I guess it's also a risk they do this now into execute_experiment and not realize it is potentially unused
There was a problem hiding this comment.
I think this is the right approach, but a warning might be useful.
We also have an existing warning (via the workflow_banner), that's likely made obsolete with the current change.
Placeholder for discussion of changing slurm workflow manager to use
execute_experiment