Add tests & bugfix for packages/trace.go#939
Add tests & bugfix for packages/trace.go#939ganochenkodg wants to merge 9 commits intoGoogleCloudPlatform:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ganochenkodg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @ganochenkodg. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| osinfo, err := p.osInfoProvider.GetOSInfo(ctx) | ||
| if err != nil { | ||
| clog.Errorf(ctx, "GetOSInfo() error: %v", err) | ||
| osinfo, oserr := p.osInfoProvider.GetOSInfo(ctx) |
There was a problem hiding this comment.
What is the reason for this change ?
There was a problem hiding this comment.
i see, an error is silenced in the scenario where GetInstalledPackages returns error
| ) | ||
|
|
||
| // mockInstalledPackagesProvider is a mock implementation of InstalledPackagesProvider. | ||
| type mockInstalledPackagesProvider struct { |
There was a problem hiding this comment.
Will gomock work here ? Please avoid creating stubs manually if they can be generated with a gomock
There was a problem hiding this comment.
Will check. Converted this PR to drfat for now, it requires an additional work
|
|
||
| // TestTracingInstalledPackagesProvider verifies that the tracing decorator | ||
| // correctly handles results and errors from the underlying providers. | ||
| func TestTracingInstalledPackagesProvider(t *testing.T) { |
There was a problem hiding this comment.
I'm not sure test is actually testing any behavior of the TracingInstalledPackagesProvider, TracingInstalledPackagesProvider created for the purpose to measure resources overhead of the specific provider, what i see test is testing is just pass through behavior.
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
2 participants
Test coverage for ./packages/trace.go:
github.com/GoogleCloudPlatform/osconfig/packages/trace.go:18: TracingInstalledPackagesProvider 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/packages/trace.go:22: GetInstalledPackages 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/packages/trace.go:43: logTraceResult 0.0% -> 100.0%
Critical bug fix in func (p tracingInstalledPackagesProvider) GetInstalledPackages(ctx context.Context) (Packages, error):
"osinfo, err := p.osInfoProvider.GetOSInfo(ctx)" could overwrite error that must be returned. Var renamed err -> oserr