Skip to content

Cover patch_linux.go by unit tests#932

Open
iliatsuprik wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
iliatsuprik:patch-linux-unittests
Open

Cover patch_linux.go by unit tests#932
iliatsuprik wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
iliatsuprik:patch-linux-unittests

Conversation

@iliatsuprik
Copy link
Copy Markdown
Contributor

This PR contains unit tests and minor changes in code for github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_linux.go.
Initial coverage: 23.4%, current coverage: 100%

The following variables were moved to be global (needed to mock them):

runAptGetUpgrade = ospatch.RunAptGetUpgrade
runYumUpdate     = ospatch.RunYumUpdate
runZypperPatch   = ospatch.RunZypperPatch
retryPeriod      = 3 * time.Minute

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iliatsuprik
Once this PR has been reviewed and has the lgtm label, please assign ekremenetskii for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link
Copy Markdown

Hi @iliatsuprik. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@burov
Copy link
Copy Markdown
Member

burov commented Mar 29, 2026

/gcbrun

@iliatsuprik iliatsuprik force-pushed the patch-linux-unittests branch from 90a4fc2 to bfcbe76 Compare March 30, 2026 09:25
@iliatsuprik iliatsuprik force-pushed the patch-linux-unittests branch from bfcbe76 to ea62e99 Compare April 7, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants