Skip to content

cloudrunv2: promote start_execution_token and run_execution_token to GA#18296

Open
bskaplan wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
bskaplan:token
Open

cloudrunv2: promote start_execution_token and run_execution_token to GA#18296
bskaplan wants to merge 3 commits into
GoogleCloudPlatform:mainfrom
bskaplan:token

Conversation

@bskaplan

Copy link
Copy Markdown
Contributor

start_execution_token and run_execution_token have been launched for a while, they're ready to move to GA.

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: added fields `start_execution_token` and `run_execution_token` to `google_cloud_run_v2_job` (ga)

@github-actions github-actions Bot requested a review from ScottSuarez July 15, 2026 17:56
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d245f7f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 180 insertions(+), 2 deletions(-)
google-beta provider View Diff 1 file changed, 2 insertions(+), 2 deletions(-)

@modular-magician

modular-magician commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 807a740:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 181 insertions(+), 3 deletions(-)
google-beta provider View Diff 2 files changed, 3 insertions(+), 3 deletions(-)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate
🔴 TestAccCloudRunV2Job_cloudrunv2JobWithStartExecutionTokenUpdate

Analytics

Total Tests Passed Skipped Affected
92 83 9 0
Affected Service Packages
  • cloudrunv2

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the replaying VCR build log

@bskaplan, @ScottSuarez, @qwerjkl112 VCR tests complete for 807a740!

@modular-magician

modular-magician commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6a6bdd0:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 181 insertions(+), 3 deletions(-)
google-beta provider View Diff 2 files changed, 3 insertions(+), 3 deletions(-)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate
🔴 TestAccCloudRunV2Job_cloudrunv2JobWithStartExecutionTokenUpdate

Analytics

Total Tests Passed Skipped Affected
92 83 9 0
Affected Service Packages
  • cloudrunv2

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the replaying VCR build log

@bskaplan, @ScottSuarez, @qwerjkl112 VCR tests complete for 6a6bdd0!

@bskaplan

Copy link
Copy Markdown
Contributor Author

Manually ran GA test:
make testacc TEST=./google/services/cloudrunv2 TESTARGS='-run=TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate' sh -c "'/usr/local/google/home/bkaplan/knative-workspace/src/github.com/bskaplan/terraform-provider-google/scripts/gofmtcheck.sh'" ==> Checking that code complies with gofmt requirements... go vet TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/cloudrunv2 -v -run=TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc" === RUN TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate === PAUSE TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate === CONT TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate --- PASS: TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate (218.99s) PASS ok github.com/hashicorp/terraform-provider-google/google/services/cloudrunv2 219.375s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants