netapp: Remove deprecated scale_tier from google_netapp_storage_pool

[raazanand]

`netapp`: The `google_netapp_storage_pool` resource no longer includes the deprecated `scale_tier` argument. This is a breaking change. Users should migrate to using the `scale_type` argument instead.

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 675e726:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	4 files changed, 8 insertions(+), 10 deletions(-)
google-beta provider	View Diff	6 files changed, 8 insertions(+), 226 deletions(-)
terraform-google-conversion	View Diff	3 files changed, 16 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field scale_tier within resource google_netapp_storage_pool was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
41	41	0	0

Affected Service Packages

• netapp

Learn how VCR tests work

---

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@raazanand, @melinath VCR tests complete for 675e726!

[raazanand]

Hi @melinath I see that two workflows are failing, and I wanted to provide some context:

terraform-google-conversion-test-integration Failure: The detailed logs show failures in tests related to google_container_cluster and google_dataplex_datascan. My changes are focused entirely on the google_netapp_storage_pool resource. The logs also indicate that the netapp service tests within this workflow passed successfully. It seems these failures are unrelated to my PR and might be pre-existing issues on the FEATURE-BRANCH-major-release-8.0.0 branch.