Skip to content

chore(vertexai): Remove controlled generation response schema region tags#5609

Open
amcolin wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
amcolin:remove-controlled-generation-response-schema-tags
Open

chore(vertexai): Remove controlled generation response schema region tags#5609
amcolin wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
amcolin:remove-controlled-generation-response-schema-tags

Conversation

@amcolin

@amcolin amcolin commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes Internal b/527153083 and b/527154093

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes region tags from controlledgen_schema6.go and controlledgen_schema_enum.go, and skips the corresponding tests in controlledgen_schema_test.go with a message indicating they are waiting to decommission vertexai. There are no review comments, and I have no feedback to provide.

@Kef131 Kef131 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amcolin
amcolin marked this pull request as ready for review June 24, 2026 20:01
@amcolin
amcolin requested review from a team as code owners June 24, 2026 20:01

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Jun 25, 2026
@snippet-bot

snippet-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants