feat(secretmanager): Adding CMEK sample#5449
Conversation
…es into golang_example
Summary of ChangesHello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Google Cloud Go samples by providing practical examples for integrating Customer-Managed Encryption Keys (CMEK) with Secret Manager. It offers clear, runnable code snippets for both globally and regionally managed secrets, enabling developers to implement robust encryption strategies using their own KMS keys. The addition of these samples improves the library's coverage for advanced security configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds new samples for creating secrets with Customer-Managed Encryption Keys (CMEK) in Secret Manager, for both global and regional secrets. The changes include the sample code itself and corresponding system tests. The implementation is straightforward and the tests are comprehensive, verifying the secret creation and the CMEK configuration. I've found one minor issue in a code comment, which I've detailed below. Overall, this is a great addition.
…es into golang_secretmanager_tag_samples
…crest/golang-samples into golang_secretmanager_expiration_samples
…khilan-crest/golang-samples into golang_secretmanager_rotation_samples
…ilan-crest/golang-samples into golang_secretmanager_delayeddestruction_samples
…hub.com:khilan-crest/golang-samples into golang_secretmanager_cmek_samples
Adding CMEK sample
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..(see Testing)gofmt(see Formatting)go vet(see Formatting)