feat(secretmanager): Adding secretmanager expiration samples#5446
feat(secretmanager): Adding secretmanager expiration samples#5446khilan-crest wants to merge 13 commits into
Conversation
…es into golang_example
Summary of ChangesHello @khilan-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Google Cloud Secret Manager Go samples by introducing new functionalities related to secret expiration. It provides clear examples for creating secrets with an initial expiration, modifying an existing secret's expiration date, and completely removing any set expiration. These samples are provided for both globally managed secrets and regionally managed secrets, ensuring comprehensive coverage for various deployment scenarios. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new samples for managing secret expiration times in Secret Manager, covering creation, updates, and deletion for both global and regional secrets. The code is well-structured and includes tests for the new functionality. I have a few suggestions to improve the reusability of the sample functions and to enhance code consistency.
…es into golang_secretmanager_tag_samples
…crest/golang-samples into golang_secretmanager_expiration_samples
|
Here is the summary of changes. You are about to add 14 region tags.
This comment is generated by snippet-bot.
|
Adding secretmanager expiration samples
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..(see Testing)gofmt(see Formatting)go vet(see Formatting)