Skip to content

fix(patch): benchmarking and unsupported_path test fixes to v3.8.3#4779

Open
PranjalC100 wants to merge 2 commits into
v3.8.3_releasefrom
patch-v3.8.3-fixes
Open

fix(patch): benchmarking and unsupported_path test fixes to v3.8.3#4779
PranjalC100 wants to merge 2 commits into
v3.8.3_releasefrom
patch-v3.8.3-fixes

Conversation

@PranjalC100

Copy link
Copy Markdown
Member

Description

This PR backports two integration test fixes to the v3.8.3_release branch for GKE.

  1. Benchmarking Fix (PR fix(integration_tests): prevent overwriting MntDir in GKE executions #4577): Prevents setup.MntDir from being overwritten by an empty directory during GKE execution.
  2. Unsupported Path Fix (PR test(integration): remove unused mount configs #4623): Resolves test failures in unsupported_path caused by path joining logic.

Linked Issues

@PranjalC100 PranjalC100 changed the base branch from master to v3.8.3_release June 15, 2026 04:14
@PranjalC100 PranjalC100 marked this pull request as ready for review June 15, 2026 04:16
@PranjalC100 PranjalC100 requested a review from a team as a code owner June 15, 2026 04:16
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports critical integration test fixes to the v3.8.3 release branch. The changes primarily focus on stabilizing GKE test environments by correcting how mount and root directories are initialized and managed, ensuring that test configurations are robust against environment-specific path overrides.

Highlights

  • Benchmarking Fix: Standardized the mount directory configuration to prevent setup.MntDir from being incorrectly overwritten during GKE execution.
  • Unsupported Path Fix: Refactored path joining logic and test configurations to resolve failures in the unsupported_path integration tests.
  • Test Infrastructure Improvements: Added rootDir tracking and updated initialization logic across multiple test suites to ensure consistent directory handling.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the integration test setup across several packages (including benchmarking, dentry_cache, stale_handle, and unfinalized_object) to consistently use local mountDir and rootDir variables instead of setup.MntDir() or conditional checks. Additionally, it updates test_config.yaml to include the only_dir parameter for specific test suites, removes unused configuration fields, and fixes indentation. There are no review comments, so I have no feedback to provide.

@PranjalC100 PranjalC100 enabled auto-merge (squash) June 15, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant