fix(patch): benchmarking and unsupported_path test fixes to v3.8.2#4778
fix(patch): benchmarking and unsupported_path test fixes to v3.8.2#4778PranjalC100 wants to merge 2 commits into
Conversation
…4577) * benchmarking mounted dir fix * changing setupMntDir for consistency * lint test fix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.8.2_release #4778 +/- ##
================================================
Coverage ? 0
================================================
Files ? 0
Lines ? 0
Branches ? 0
================================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request backports critical integration test fixes to the v3.8.2_release branch. The changes primarily focus on stabilizing GKE execution environments by ensuring consistent mount directory management and correcting path-related logic that previously caused test failures. These adjustments improve the reliability of the benchmarking and unsupported path test suites. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the integration test setup across multiple test suites (including benchmarking, dentry_cache, stale_handle, and unfinalized_object) to consistently use local mountDir and rootDir variables instead of conditionally querying testEnv.cfg or setup.MntDir(). Additionally, it updates test_config.yaml to include the only_dir parameter for certain test suites, removes unused configuration keys, and cleans up formatting. There are no review comments, so I have no feedback to provide.
Description
This PR backports two integration test fixes to the
v3.8.2_releasebranch for GKE.setup.MntDirfrom being overwritten by an empty directory during GKE execution.unsupported_pathcaused by path joining logic.Linked Issues