Skip to content

fix(patch): benchmarking and unsupported_path test fixes to v3.8.2#4778

Open
PranjalC100 wants to merge 2 commits into
v3.8.2_releasefrom
patch-v3.8.2-fixes
Open

fix(patch): benchmarking and unsupported_path test fixes to v3.8.2#4778
PranjalC100 wants to merge 2 commits into
v3.8.2_releasefrom
patch-v3.8.2-fixes

Conversation

@PranjalC100

@PranjalC100 PranjalC100 commented Jun 15, 2026

Copy link
Copy Markdown
Member

Description

This PR backports two integration test fixes to the v3.8.2_release branch for GKE.

  1. Benchmarking Fix (PR fix(integration_tests): prevent overwriting MntDir in GKE executions #4577): Prevents setup.MntDir from being overwritten by an empty directory during GKE execution.
  2. Unsupported Path Fix (PR test(integration): remove unused mount configs #4623): Resolves test failures in unsupported_path caused by path joining logic.

Linked Issues

@PranjalC100 PranjalC100 changed the title Patch v3.8.2 fixes fix(patch) benchmarking and unsupported_path test fixes to v3.8.2 Jun 15, 2026
@PranjalC100 PranjalC100 changed the title fix(patch) benchmarking and unsupported_path test fixes to v3.8.2 fix(patch): benchmarking and unsupported_path test fixes to v3.8.2 Jun 15, 2026
@PranjalC100 PranjalC100 marked this pull request as ready for review June 15, 2026 04:16
@PranjalC100 PranjalC100 requested a review from a team as a code owner June 15, 2026 04:16
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v3.8.2_release@40dad1d). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             v3.8.2_release   #4778   +/-   ##
================================================
  Coverage                  ?       0           
================================================
  Files                     ?       0           
  Lines                     ?       0           
  Branches                  ?       0           
================================================
  Hits                      ?       0           
  Misses                    ?       0           
  Partials                  ?       0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports critical integration test fixes to the v3.8.2_release branch. The changes primarily focus on stabilizing GKE execution environments by ensuring consistent mount directory management and correcting path-related logic that previously caused test failures. These adjustments improve the reliability of the benchmarking and unsupported path test suites.

Highlights

  • Benchmarking Fix: Updated the benchmarking setup to correctly set the mount directory, preventing it from being overwritten by an empty directory during GKE execution.
  • Unsupported Path Fix: Resolved test failures in the unsupported_path suite by refining the configuration and path joining logic in the test environment.
  • Test Configuration Updates: Standardized the handling of mount and root directories across multiple integration test suites and updated the test configuration YAML to support necessary directory parameters.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the integration test setup across multiple test suites (including benchmarking, dentry_cache, stale_handle, and unfinalized_object) to consistently use local mountDir and rootDir variables instead of conditionally querying testEnv.cfg or setup.MntDir(). Additionally, it updates test_config.yaml to include the only_dir parameter for certain test suites, removes unused configuration keys, and cleans up formatting. There are no review comments, so I have no feedback to provide.

@PranjalC100 PranjalC100 enabled auto-merge (squash) June 15, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant