test(integration): migrate TPC operations tests to config file#4763
test(integration): migrate TPC operations tests to config file#4763PranjalC100 wants to merge 3 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the integration testing framework by unifying TPC endpoint test execution with the existing configuration-driven approach. By moving hardcoded test parameters into the common YAML configuration, the codebase becomes more maintainable and consistent with other test suites, while also simplifying the test entry point. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4763 +/- ##
==========================================
- Coverage 83.72% 0 -83.73%
==========================================
Files 168 0 -168
Lines 20776 0 -20776
==========================================
- Hits 17395 0 -17395
+ Misses 2736 0 -2736
+ Partials 645 0 -645
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request refactors the integration tests for operations by removing hardcoded TPC configurations and helper functions in operations_test.go in favor of using the shared YAML configuration file. It introduces a TPCOnly field in the test configuration struct to filter TPC-specific test cases. The reviewer recommended renaming the TPCOnly struct field to TPC to maintain consistency with its YAML tag tpc and suggested a more flexible logic for partitioning TPC and non-TPC test cases.
meet2mky
left a comment
There was a problem hiding this comment.
TPC Build is still failing. Please see the kokoro failure.
|
Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
10 similar comments
|
Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
|
Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
|
Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
|
Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
|
Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
|
Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
|
Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
|
Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
|
Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
|
Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you! |
Description
Migrates the
operationsintegration tests on TPC endpoint to execute from the common configuration file (test_config.yaml).tpcboolean property toConfigItemto identify TPC-specific configurations.flat/hns/zonalcompatibility for TPC configurations intest_config.yaml, combined withtpc: true.BuildFlagSets()insetup.goto filter configurations based on whether the test is running on a TPC endpoint.RunTestOnTPCEndPointflow inoperations_test.goand handles it within the standard config setup.operations_test.goand uses package-level ones instead.Link to the issue in case of a bug fix.
Fixes b/469970353
Testing details
go test -c ./tools/integration_tests/operationsand checked general repo lint/compilation usingmake buildTest.Any backward incompatible change? If so, please explain.
N/A