Skip to content

test(integration): migrate TPC operations tests to config file#4763

Open
PranjalC100 wants to merge 3 commits into
masterfrom
tpc-build
Open

test(integration): migrate TPC operations tests to config file#4763
PranjalC100 wants to merge 3 commits into
masterfrom
tpc-build

Conversation

@PranjalC100

Copy link
Copy Markdown
Member

Description

Migrates the operations integration tests on TPC endpoint to execute from the common configuration file (test_config.yaml).

  • Adds a new tpc boolean property to ConfigItem to identify TPC-specific configurations.
  • Declares standard flat/hns/zonal compatibility for TPC configurations in test_config.yaml, combined with tpc: true.
  • Modifies BuildFlagSets() in setup.go to filter configurations based on whether the test is running on a TPC endpoint.
  • Deletes the custom/hardcoded RunTestOnTPCEndPoint flow in operations_test.go and handles it within the standard config setup.
  • Cleans up redundant local helpers in operations_test.go and uses package-level ones instead.

Link to the issue in case of a bug fix.

Fixes b/469970353

Testing details

  1. Manual - Checked local compilation using go test -c ./tools/integration_tests/operations and checked general repo lint/compilation using make buildTest.
  2. Unit tests - N/A
  3. Integration tests - N/A (requires TPC endpoint and credentials)

Any backward incompatible change? If so, please explain.

N/A

@PranjalC100 PranjalC100 added execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket. labels Jun 6, 2026
@PranjalC100 PranjalC100 requested a review from anushka567 June 6, 2026 10:45
@PranjalC100 PranjalC100 marked this pull request as ready for review June 6, 2026 10:46
@PranjalC100 PranjalC100 requested review from a team and meet2mky as code owners June 6, 2026 10:46
@PranjalC100 PranjalC100 requested a review from geertj June 6, 2026 10:46
@github-actions github-actions Bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Jun 6, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the integration testing framework by unifying TPC endpoint test execution with the existing configuration-driven approach. By moving hardcoded test parameters into the common YAML configuration, the codebase becomes more maintainable and consistent with other test suites, while also simplifying the test entry point.

Highlights

  • TPC Configuration Migration: Migrated TPC-specific integration tests from hardcoded logic in operations_test.go to the centralized test_config.yaml configuration file.
  • Config Schema Update: Added a tpc boolean property to ConfigItem to identify and filter TPC-specific test configurations.
  • Logic Refactoring: Updated BuildFlagSets in setup.go to handle TPC compatibility filtering and removed redundant local helper functions in the operations test suite.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@PranjalC100 PranjalC100 removed the request for review from geertj June 6, 2026 10:46
@codecov

codecov Bot commented Jun 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (d046938) to head (e574496).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #4763       +/-   ##
==========================================
- Coverage   83.72%       0   -83.73%     
==========================================
  Files         168       0      -168     
  Lines       20776       0    -20776     
==========================================
- Hits        17395       0    -17395     
+ Misses       2736       0     -2736     
+ Partials      645       0      -645     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the integration tests for operations by removing hardcoded TPC configurations and helper functions in operations_test.go in favor of using the shared YAML configuration file. It introduces a TPCOnly field in the test configuration struct to filter TPC-specific test cases. The reviewer recommended renaming the TPCOnly struct field to TPC to maintain consistency with its YAML tag tpc and suggested a more flexible logic for partitioning TPC and non-TPC test cases.

Comment thread tools/integration_tests/util/test_suite/config.go Outdated
Comment thread tools/integration_tests/util/setup/setup.go Outdated

@meet2mky meet2mky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TPC Build is still failing. Please see the kokoro failure.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

10 similar comments
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions

Copy link
Copy Markdown

Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions

Copy link
Copy Markdown

Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions

Copy link
Copy Markdown

Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions

Copy link
Copy Markdown

Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions

Copy link
Copy Markdown

Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions

Copy link
Copy Markdown

Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions

Copy link
Copy Markdown

Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions

Copy link
Copy Markdown

Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

@github-actions

Copy link
Copy Markdown

Hi @anushka567, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests execute-integration-tests-on-zb To run E2E tests on zonal bucket. remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants