feat(skills): add code-review skill for GCSFuse#4741
Draft
kislaykishore wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new, highly refined custom code-review and quality assurance skill runbook under
.gemini/skills/code-review/SKILL.md.This developer utility skill equips AI agents (such as Antigravity) with localized engineering knowledge of:
locker.New&locker.NewRWtracking locks held for >5s), locking boundaries (releasing mutexes prior to remote network or disk calls), and avoiding lock contentions under parallel reads (JAX/PyTorch model checkpoints).--implicit-dirsversus explicit directory placeholders, and folder rename consistency (HNS buckets vs flat bucket copying).TmpObjectPrefixfor sequential write appends exceeding threshold boundaries, and periodic garbage collection sweeps to purge residual temporary files.fs/,gcs/,file_cache/,buffered_read/,grpc.,read/), otherwise the OpenTelemetry exporter silently discards them during aggregation.implicit_dir,mounting,read_cache,concurrent_operations,stale_handle,monitoring,readonly).Link to the issue in case of a bug fix.
N/A
Testing details
make buildsuccessfully with exit status0(0 issues).Any backward incompatible change? If so, please explain.
N/A