Repository navigation
Conversation
- statistics_test: the denied quota cache entry is re-checked with the server on every cache flush, so allocate_quota.PERMISSION_DENIED keeps growing and its value at a fixed fetch time varies. Assert a minimum instead. StatsVerifier.CheckExpectedCounters now also polls for up to 10s while a counter is still below its expected value. - access_log_test: Envoy writes the access log asynchronously. Poll the file for up to 15s instead of reading it once. - transport_security_test: with TLS 1.3, the client can write the request after Envoy has rejected the client cert and closed the connection, so the error is EPIPE/ECONNRESET instead of the TLS alert. Retry on a new connection in that case. - managed_service_config_test: after the 429, ConfigManager only serves ADS after its 10s retry, and Envoy's ADS reconnect backoff can add up to 30s more. Allow 60s for the Envoy health check. - config_manager_test: widen the timing margin of TestRetryCallServiceManagement from 50ms to 900ms. 50ms was too tight for -race runs. - TSan: run the tests with ASLR disabled. clang-14 TSan aborts with "unexpected memory mapping" on hosts with a high vm.mmap_rnd_bits. - e2e: deploy the Cloud Function as 1st gen on nodejs22 (nodejs12 is decommissioned and gcloud now defaults to 2nd gen). Move the App Engine bookstore to nodejs22 and remove the resources section, which App Engine standard now rejects.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: liusc28 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @TigerSunWork |
|
@liusc28: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Presubmits on open PRs (e.g. #1041, #1042) keep failing on tests and jobs unrelated to the change under review. This PR fixes those failures. It only changes tests, test scripts and CI config; no product code.
Flaky tests
TestStatisticsServiceControlCallStatus("quota call is 403") (example:expected value: 3, got value: 2)allocate_quota.PERMISSION_DENIEDkeeps growing. The test read it once, 3s after the request, so the value depended on timing.StatsVerifier.CheckMinimumCounters.CheckExpectedCountersnow also keeps polling (up to 10s) while a counter is below its expected value, and still fails as soon as a counter goes above it.TestAccessLog(example)TestDownstreamMTLS(example:write: broken pipeinstead oftls: unknown certificate authority)EPIPE/ECONNRESET), retry on a new connection, up to 5 attempts.TestRetryCallServiceManagement(integration) (example)TestEnv.SetEnvoyHealthCheckRetries; this test uses 20 retries (60s).TestRetryCallServiceManagement(unit,src/go/configmanager) (example)-race.Broken CI jobs
ESPv2-presubmit-tsan(example:FATAL: ThreadSanitizer: unexpected memory mapping)vm.mmap_rnd_bits. Only the 2 tests that weren't remote-cache hits actually ran, and both failed.test:clang-tsan --run_under="setarch --addr-no-randomize", as the integration tests already do for Envoy. This changes the test action keys, so the first run re-executes all TSan tests.ESPv2-cloud-run-e2e-cloud-function-http-bookstore(example:nodejs12 is not a supported runtime on GCF 2nd gen)gcloud functions deploycreates 2nd gen functions by default, andnodejs12is not available there (it is also decommissioned on 1st gen).--no-gen2 --runtime nodejs22. The script relies on 1st gen behavior (httpsTrigger.url,roles/cloudfunctions.invoker).ESPv2-cloud-run-e2e-app-engine-http-bookstore(example:Resources is not supported for App Engine Standard Environment)resourcessection, which only applies to the flexible environment, and move from the deprecatednodejs18tonodejs22.Not fixed
These are infra issues and are not addressed here:
ESPv2-anthos-cloud-run-e2e-anthos-cloud-run-http-bookstore: GKE cluster creation fails withINTERNAL(example).ESPv2-presubmit-asan: hits the 2h job timeout while still linking test binaries (example).Testing
gofmt,goimports,go vetandmisspellpass on the changed files.go test ./src/go/configmanager -run TestRetryCallServiceManagement -race -count=5 -cpu=1passes.go test ./tests/env/components/passes.