Add labels to GCS bucket and secrets created by compose#298
Add labels to GCS bucket and secrets created by compose#298harish-sharma-94 wants to merge 4 commits into
Conversation
|
/gemini review |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces GCP labeling for created secrets and storage buckets by adding a labels parameter to creation functions and implementing a sanitizeLabelValue helper. Review feedback points out that sanitizeLabelValue could throw a TypeError if passed a non-string value (like a number) and unnecessarily prepends 'p-' to values starting with numbers, which are valid GCP label values. Suggestions were made to convert the input to a string, update the regex to allow leading numbers, and adjust the corresponding unit tests.
There was a problem hiding this comment.
Code Review
This pull request introduces GCP labeling for created storage buckets and secrets. It adds a sanitizeLabelValue helper function to ensure label values comply with GCP constraints, integrates label application into the compose deployment flow, and adds comprehensive unit tests. The review feedback correctly identifies that GCP label values are allowed to start with a number, making the prepending of 'p-' unnecessary for those cases, and provides suggestions to fix both the helper function and its tests.
|
/gemini review |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
3 participants
This PR introduces labels to Google Cloud Storage (GCS) buckets and Secret Manager secrets created during Cloud Run Compose deployments. This aligns the MCP server's behavior with gcloud run compose to help track and identify resources associated with specific compose projects.