Skip to content

Add Iceberg to AlloyDB YAML template#3932

Open
ihebimad wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
ihebimad:feature/iceberg-to-alloydb
Open

Add Iceberg to AlloyDB YAML template#3932
ihebimad wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
ihebimad:feature/iceberg-to-alloydb

Conversation

@ihebimad

Copy link
Copy Markdown
Contributor

Successful IT JobID : 2026-06-19_09_54_35-1302943962825921393

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new YAML-based Dataflow template designed to facilitate batch data migration from Apache Iceberg tables to AlloyDB. The changes include the core template definition, parameter configurations, documentation, and a robust integration test to ensure reliability.

Highlights

  • New Template Addition: Added a new YAML-based Dataflow template for migrating data from Apache Iceberg tables to AlloyDB.
  • Configuration and Documentation: Included necessary configuration files, documentation, and parameter definitions to support the new Iceberg to AlloyDB pipeline.
  • Integration Testing: Implemented a comprehensive integration test suite to verify the end-to-end functionality of the new template.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the "Iceberg to AlloyDB (YAML)" batch pipeline template, including its Java metadata interface, YAML pipeline definition, configuration options, documentation, and integration tests. The review feedback identifies several critical issues: syntax errors in the YAML template's filesToCopy and requirements properties, the need to make the alloydbTable parameter mandatory rather than optional, the removal of the unused and unsupported query parameter across the interface and configurations, and a correction to the Terraform directory path in the README.

Comment thread yaml/src/main/yaml/IcebergToAlloyDB.yaml
Comment thread yaml/src/main/yaml/IcebergToAlloyDB.yaml
Comment thread yaml/src/main/yaml/IcebergToAlloyDB.yaml
Comment thread yaml/src/main/python/options/alloydb_options.yaml
Comment thread yaml/src/main/python/options/alloydb_options.yaml
[terraform workflow](https://developer.hashicorp.com/terraform/intro/core-workflow):

```shell
cd v2/yaml/terraform/Iceberg_To_AlloyDB_Yaml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The directory path is documented as v2/yaml/terraform/..., but the module is located under yaml/terraform/... in this repository. This should be corrected to avoid confusion when users try to navigate to the Terraform directory.

Suggested change
cd v2/yaml/terraform/Iceberg_To_AlloyDB_Yaml
cd yaml/terraform/Iceberg_To_AlloyDB_Yaml

@derrickaw derrickaw Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it should be fixed in code to render correctly here. Let me open a separate PR to fix.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks derrickaw, sure, please let me know if anything else is needed from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants