Add project-context.md for sourcedb-to-spanner#3899
Conversation
7f5a4d6 to
ac452be
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces documentation and architectural diagrams for the sourcedb-to-spanner Dataflow template. The addition of a project context file and visual architecture mapping aims to improve onboarding and provide a clear reference for the pipeline's design, technical stack, and operational procedures. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds architecture documentation for the sourcedb-to-spanner pipeline, including a Graphviz DOT file, its SVG rendering, and a comprehensive project context markdown file (project-context.md). The review feedback recommends correcting a hardcoded local user directory path to a relative path, and resolving inconsistent project variable names (PROJECT vs PROJECT_ID) alongside replacing hardcoded testing resources with generic placeholders in the build and run commands.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
VardhanThigle
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the change request. A few open points for discussion.
|
How is this different from a README?
…On Tue, 9 Jun 2026 at 12:14 PM, Vardhan Vinay Thigle < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In v2/sourcedb-to-spanner/project-context.md
<#3899 (comment)>
:
> + * [CS Reader for Bulk Migration](http://go/cs-reader-for-bulk-migration-to-spanner) - Reader design.
+ * [Spanner Bulk Migration User Guide](http://go/spanner-bulk-migration-user-guide) - Usage instructions.
+* **Architecture Diagram:** [architecture.svg](architecture.svg)
+
+## AI Agent Tips
+
+* **Common Tasks:** Adding new JDBC dialects, fixing parsing errors, implementing new transformations or schema overrides, adding new source reader capabilities.
+* **Coding Standards & Best Practices:**
+ * Use `AutoValue` for POJOs.
+ * Strict adherence to Apache Beam paradigms (PTransforms, DoFns). Use `TupleTag` for side outputs like the DLQ.
+ * Use structured logging (`com.google.cloud.teleport.structured-logging`).
+* **Testing Frameworks & Guidelines:**
+ * **Frameworks:** JUnit 4, Google Truth for assertions, Mockito for mocking.
+ * **Rules:** Ensure tests use ***@***.***(JUnit4.class)`. Use embedded databases for testing when possible (e.g. `derby` or `embedded-cassandra`).
+* **Areas to be Careful:** Cross-shard querying logic, causal ordering around the DLQ, and schema mappings parsing.
+* **Example CLs:**
It's a PR and not a CL
—
Reply to this email directly, view it on GitHub
<#3899?email_source=notifications&email_token=ABSOX5SJGQSPXKIWLAVUXL3466W5LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBVGU4TGNJZGEY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#pullrequestreview-4455935911>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSOX5VL55U6LRG4NPFBMA3466W5LAVCNFSM6AAAAAC2AKSSEOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DINJVHEZTKOJRGE>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ABSOX5UN4MPPSWBZGMYUYGL466W5LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBVGU4TGNJZGEY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ>
and Android
<https://github.com/notifications/mobile/android/ABSOX5RRMMCUQJQAPCTDQB3466W5LA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBVGU4TGNJZGEY2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: <GoogleCloudPlatform/DataflowTemplates/pull/3899/review/4455935911@
github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3899 +/- ##
============================================
+ Coverage 55.55% 63.30% +7.75%
+ Complexity 7022 2317 -4705
============================================
Files 1103 514 -589
Lines 67557 29969 -37588
Branches 7576 3303 -4273
============================================
- Hits 37529 18972 -18557
+ Misses 27612 10031 -17581
+ Partials 2416 966 -1450
🚀 New features to boost your workflow:
|
96e61af to
f0c315d
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
b/521647942