Skip to content

Sample for chrome.management #1102 - #1105

Open
An-Yay wants to merge 11 commits into
GoogleChrome:mainfrom
An-Yay:main
Open

Sample for chrome.management #1102#1105
An-Yay wants to merge 11 commits into
GoogleChrome:mainfrom
An-Yay:main

Conversation

@An-Yay

@An-Yay An-Yay commented Feb 23, 2024

Copy link
Copy Markdown

Hey,
I have created the sample for chrome.management #1102 API showing the functions that you recommended. Please let me know of any changes or improvements on the same.

Regards,
Ananay

@An-Yay

An-Yay commented Feb 23, 2024

Copy link
Copy Markdown
Author

I noticed that samples for wallpaper, types, and TTS (text-to-speech) are missing. I'd be happy to contribute these samples. Please assign them to me. Thank you!

@jpmedley jpmedley left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this. I reviewed the README. Please don't let the number of requested changes scare you. From a purely writing standpoint, your README doesn't have any errors. However, I had to change a bunch of stuff to follow company standards for writing.

Comment thread api-samples/management/README.md Outdated
Comment thread api-samples/management/README.md Outdated
Comment thread api-samples/management/README.md Outdated
Comment thread api-samples/management/README.md Outdated
Comment thread api-samples/management/README.md Outdated
Comment thread api-samples/management/README.md Outdated
Comment thread api-samples/management/README.md Outdated
Comment thread api-samples/management/README.md Outdated
Comment thread api-samples/management/README.md Outdated
An-Yay and others added 9 commits February 26, 2024 22:56
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>

@An-Yay An-Yay left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have gone through all the suggestions, I'd like to appreciate the time you've put in to correct and fix my Readme. I'll make sure to follow the format for the same for the rest of the PRs

@An-Yay An-Yay left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gone through the changes

@An-Yay
An-Yay requested a review from jpmedley February 26, 2024 17:43
@jpmedley

Copy link
Copy Markdown

I have gone through all the suggestions, I'd like to appreciate the time you've put in to correct and fix my Readme. I'll make sure to follow the format for the same for the rest of the PRs

I appreciate that, but we don't expect your work to be perfect. That's why I'm paid to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants