update DNR samples to work in new DCC#1083
Conversation
|
Hi, I came here from the discussion on #1082 as I was having the same issue. However this fix also doesn't seem to change things, and somewhere down the line the changes were reverted? Edit: I understand that the original user with the issue also didn't see anything get fixed when they tried this fix. However, they did see the desired outcome when they removed the resourceType section altogether. This doesn't seem to happen on my end, however. There is a message, as before, indicating the redirection, but no actual redirection occurs. |
developer.chrome.com serves navigations through its service worker for returning visitors, so there is no main_frame network request for these rules to match. Match the service worker's xmlhttprequest as well, and update the redirect destinations that have since moved.
2f3be94 to
71d3378
Compare
|
@oliverdunk finally got back to this. I dug into why the reports here were inconsistent: developer.chrome.com serves navigations through its service worker for returning visitors, so there is no Matching Given the sample now needs that caveat explained to make sense, does it still seem worth merging, or would you rather we abandon it? |
fixes #1082