Skip to content

fix: temporary patch for Fastly service lookup domain#118

Merged
vigneshrajsb merged 1 commit intomainfrom
patch/fastly-purge-cache-lookup
Mar 1, 2026
Merged

fix: temporary patch for Fastly service lookup domain#118
vigneshrajsb merged 1 commit intomainfrom
patch/fastly-purge-cache-lookup

Conversation

@vigneshrajsb
Copy link
Contributor

@vigneshrajsb vigneshrajsb commented Mar 1, 2026

Summary

This PR applies a temporary compatibility patch for Fastly service lookup naming in Lifecycle.

Current lookup logic builds Fastly service names using:

  • fastly.${domainDefaults.http}

In our environment, domainDefaults.http and the fasly urls are different

This mismatch causes lookup failures and prevents Fastly-dependent PR comment actions from rendering (for example the purge checkbox).

Change

In src/server/lib/fastly.ts, getFastlyUrl() now uses a temporary normalization:

  • return `fastly.${domainDefaults.http.replace(/^lifecycle\./, '')}`;

Why temporary

This is intentionally a short-term fix to unblock lookup behavior.
Fastly integration should be reworked into a dedicated app/service and driven by explicit Fastly domain/config instead of deriving from domainDefaults.http.

Inline comments were added in code to make this temporary status explicit.

Risk / Impact

  • Scope is limited to Fastly lookup/purge/dashboard URL resolution paths.
  • No global domainDefaults.http behavior was changed.
  • Existing behavior for non-lifecycle. domains remains unchanged.

Follow-up

  • Move Fastly logic out of this app into dedicated integration service.
  • Replace this normalization with explicit Fastly base domain config per environment.

@vigneshrajsb vigneshrajsb requested a review from a team as a code owner March 1, 2026 22:46
@vigneshrajsb vigneshrajsb force-pushed the patch/fastly-purge-cache-lookup branch from 7c05c10 to e698b62 Compare March 1, 2026 22:50
@vigneshrajsb vigneshrajsb merged commit c6aeb57 into main Mar 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant