fix: temporary patch for Fastly service lookup domain#118
Merged
vigneshrajsb merged 1 commit intomainfrom Mar 1, 2026
Merged
Conversation
7c05c10 to
e698b62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies a temporary compatibility patch for Fastly service lookup naming in Lifecycle.
Current lookup logic builds Fastly service names using:
fastly.${domainDefaults.http}In our environment,
domainDefaults.httpand the fasly urls are differentThis mismatch causes lookup failures and prevents Fastly-dependent PR comment actions from rendering (for example the purge checkbox).
Change
In
src/server/lib/fastly.ts,getFastlyUrl()now uses a temporary normalization:return `fastly.${domainDefaults.http.replace(/^lifecycle\./, '')}`;Why temporary
This is intentionally a short-term fix to unblock lookup behavior.
Fastly integration should be reworked into a dedicated app/service and driven by explicit Fastly domain/config instead of deriving from
domainDefaults.http.Inline comments were added in code to make this temporary status explicit.
Risk / Impact
domainDefaults.httpbehavior was changed.lifecycle.domains remains unchanged.Follow-up