Skip to content

Fix: fixed webpack build errors#515

Open
blueogin wants to merge 11 commits intomasterfrom
fix/webpack-build-errors
Open

Fix: fixed webpack build errors#515
blueogin wants to merge 11 commits intomasterfrom
fix/webpack-build-errors

Conversation

@blueogin
Copy link
Collaborator

@blueogin blueogin commented Feb 18, 2026

Description

Fixed 3 webpack module resolution errors by adding missing transitive dependencies: @aws-sdk/client-sso-oidc (required by AWS S3 client), @aws-sdk/client-lambda (required by OpenZeppelin Defender), and err-code (required by IPFS/Veramo). The build now completes successfully with 0 errors.

About # (link your issue here)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • PR title matches follow: (Feature|Bug|Chore) Task Name
  • My code follows the style guidelines of this project
  • I have followed all the instructions described in the initial task (check Definitions of Done)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added reference to a related issue in the repository
  • I have added a detailed description of the changes proposed in the pull request. I am as descriptive as possible, assisting reviewers as much as possible.
  • I have added screenshots related to my pull request (for frontend tasks)
  • I have pasted a gif showing the feature.
  • @mentions of the person or team responsible for reviewing proposed changes

Summary by Sourcery

Resolve webpack build issues by updating runtime dependencies.

Bug Fixes:

  • Fix webpack module resolution errors by adding missing transitive dependencies required by AWS SDK, OpenZeppelin Defender, and IPFS/Veramo integrations.

Build:

  • Add @aws-sdk/client-lambda, @aws-sdk/client-sso-oidc, err-code, and acorn-import-assertions as application dependencies to satisfy bundler requirements.
  • Bump @gooddollar/kms-ethereum-signing dependency to the latest patch version and regenerate the lockfile.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since these packages are used only to satisfy transitive resolution issues, consider checking whether upgrading the upstream libraries (e.g., AWS SDK-related packages, IPFS/Veramo) would remove the need to declare them as direct dependencies and avoid long-term maintenance of extra top-level deps.
  • The PR description explains the new AWS and err-code dependencies but not the addition of acorn-import-assertions; please clarify what requires it and why it needs to be a direct dependency, so future maintainers understand its purpose.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since these packages are used only to satisfy transitive resolution issues, consider checking whether upgrading the upstream libraries (e.g., AWS SDK-related packages, IPFS/Veramo) would remove the need to declare them as direct dependencies and avoid long-term maintenance of extra top-level deps.
- The PR description explains the new AWS and err-code dependencies but not the addition of `acorn-import-assertions`; please clarify what requires it and why it needs to be a direct dependency, so future maintainers understand its purpose.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments