Open
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since these packages are used only to satisfy transitive resolution issues, consider checking whether upgrading the upstream libraries (e.g., AWS SDK-related packages, IPFS/Veramo) would remove the need to declare them as direct dependencies and avoid long-term maintenance of extra top-level deps.
- The PR description explains the new AWS and err-code dependencies but not the addition of
acorn-import-assertions; please clarify what requires it and why it needs to be a direct dependency, so future maintainers understand its purpose.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since these packages are used only to satisfy transitive resolution issues, consider checking whether upgrading the upstream libraries (e.g., AWS SDK-related packages, IPFS/Veramo) would remove the need to declare them as direct dependencies and avoid long-term maintenance of extra top-level deps.
- The PR description explains the new AWS and err-code dependencies but not the addition of `acorn-import-assertions`; please clarify what requires it and why it needs to be a direct dependency, so future maintainers understand its purpose.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…n and package-lock.json
… additional readiness checks and error handling
…or improved test reliability
…ronment categorization
…add @aws-sdk/client-s3 and @aws-sdk/client-sso dependencies
… @aws-sdk/client-lambda, and refine jest.config.js to exclude secp256k1 from transformation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed 3 webpack module resolution errors by adding missing transitive dependencies: @aws-sdk/client-sso-oidc (required by AWS S3 client), @aws-sdk/client-lambda (required by OpenZeppelin Defender), and err-code (required by IPFS/Veramo). The build now completes successfully with 0 errors.
About # (link your issue here)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist:
Summary by Sourcery
Resolve webpack build issues by updating runtime dependencies.
Bug Fixes:
Build: