Skip to content

Small adjustment for 3D CRS awareness#879

Open
rhugonnet wants to merge 2 commits into
GlacioHack:mainfrom
rhugonnet:3d_crs_changes
Open

Small adjustment for 3D CRS awareness#879
rhugonnet wants to merge 2 commits into
GlacioHack:mainfrom
rhugonnet:3d_crs_changes

Conversation

@rhugonnet
Copy link
Copy Markdown
Member

Required for GlacioHack/xdem#656

@marinebcht
Copy link
Copy Markdown
Contributor

Hello @rhugonnet
I was wondering about the new CRS format in the info(). Is the CRS "name" is more common when we have an EPSG code like EPSG:XXXX ? Thanks :)

@rhugonnet
Copy link
Copy Markdown
Member Author

@marinebcht I'm not sure I understand the question fully.
In short:

  • Not all CRS have an EPSG code.
  • All CRS have a name.
    Mostly, the code doesn't tell you what CRS it is (you'd have to look up online what the number corresponds to), while the name is human-readable (which is the point of info())

@marinebcht
Copy link
Copy Markdown
Contributor

marinebcht commented Apr 13, 2026

@rhugonnet Okay, we had the impression that the EPSG:XXX format, when it exists, was the most common.
Thank you for the explanation !

@rhugonnet
Copy link
Copy Markdown
Member Author

It is the most common code format, but not a name (not human-readable) 😉

@marinebcht
Copy link
Copy Markdown
Contributor

Hello @rhugonnet, following this problem #805 (comment), I retrieved your PR and applied the corrections with the same logic you did here on PC and Vector + tests (did not write the georeferenced_grid_equal test [yet?], only for pc)
I can propose the corresponding PR https://github.com/marinebcht/geoutils/tree/805_pc_info or you can take my commits if you wish to add some more things :)

@rhugonnet
Copy link
Copy Markdown
Member Author

@marinebcht Perfect, do you want to add this here directly? That's the easiest I think.

Just follow these steps to push on my branch (adding a git merge from your other branch): https://github.com/GlacioHack/xdem/wiki/Work-on-someone-else's-PR

@marinebcht
Copy link
Copy Markdown
Contributor

Here my branch from yours https://github.com/marinebcht/geoutils/tree/3d_crs_changes_marine (due to direct push error...)
Thanks :)

@rhugonnet
Copy link
Copy Markdown
Member Author

Will take care of it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants