Simplify gix-protocol handshake API #2250
Merged
+8
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
rm-handshake-layers
branch
from
41acbd4 to
9f012ac
Compare
… that remove the `server` parameter.
Byron
force-pushed
the
rm-handshake-layers
branch
from
9f012ac to
c9a97db
Compare
Byron
approved these changes
Nov 9, 2025
Member
There was a problem hiding this comment.
Thanks for the simplification, it's appreciated!
Please note that it would also be beneficial to see more of a reasoning for certain changes, particularly the breaking ones. I basically rolled back the parameter removal as it makes no sense to me, and there is nothing to discuss as the reasoning is missing.
Those breaking changes will also have to be marked with conventional commits, or they have the potential for being ecosystem breaking, particularly if I don't catch them and we are unlucky enough and there was no other breaking change that would cause the crate to receive a minor version bump nonetheless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.