[Enhancement]Stereo Playout implementation #989
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/StreamVideo/Utils/Store/StoreTask.swift
ipavlidakis
changed the base branch from
develop
to
enhancement/hifi/feature-implementation
| let answer = try await createAnswer() | ||
| try await setLocalDescription(answer) | ||
| var answer = try await createAnswer() | ||
| if mungeSubscriberStereo { |
Contributor
There was a problem hiding this comment.
We need to test with RTMP tracks, to make sure we don't have the same issue as before.
| .sink { [weak self] in self?.isStereoPlayoutEnabledSubject.send($0) } | ||
| .store(in: disposableBag) | ||
|
|
||
| source |
Contributor
There was a problem hiding this comment.
nit: the spacing here is inconsistent - initially there's a new row and then not
| .sink { [weak self] in self?.isVoiceProcessingEnabledSubject.send($0) } | ||
| .store(in: disposableBag) | ||
| source | ||
| .isVoiceProcessingAGCEnabledPublisher() |
Contributor
There was a problem hiding this comment.
what does AGC mean?
| // Adds ".allowBluetoothHFP" if present, permitting audio playback through | ||
| // Bluetooth devices. | ||
| if contains(.allowBluetoothHFP) { | ||
| options.append(".allowBluetoothHFP") |
Contributor
There was a problem hiding this comment.
why are these passed as strings? Easy to make a typo.
| self.isExternal = Self.externalPorts.contains(source.portType) | ||
| self.isSpeaker = source.portType == .builtInSpeaker | ||
| self.isReceiver = source.portType == .builtInReceiver | ||
| self.channels = source.channels?.endIndex ?? 0 |
Contributor
There was a problem hiding this comment.
shouldn't it be 1 by default?
| private let source: RTCAudioSession | ||
|
|
||
| init(_ source: AudioSessionProtocol) { | ||
| init(_ source: RTCAudioSession) { |
Contributor
There was a problem hiding this comment.
I think we introduced the protocol for testing. Would this make things more difficult to test?
ipavlidakis
force-pushed
the
enhancement/hifi/stereo-playout-implementation
branch
from
7a64a7a to
99d52bd
Compare
Public Interface+ public final class RTCAudioStore: @unchecked Sendable
+
+ public var state: Namespace.State
+
+
+ public func publisher(_ keyPath: KeyPath<Namespace.State, V>)-> AnyPublisher<V, Never>
+ extension RTCAudioStore: InjectionKey
+
+ public nonisolated static var currentValue: RTCAudioStore
+ public enum Namespace: StoreNamespace
public class Call: @unchecked Sendable, WSEventsSubscriber
- public func enableClientCapabilities(_ capabilities: Set<ClientCapability>)async
+ public func updateStereoPlayoutEnforcementOnExternalDevices(_ isEnforced: Bool)async
- public func disableClientCapabilities(_ capabilities: Set<ClientCapability>)async
+ public func enableClientCapabilities(_ capabilities: Set<ClientCapability>)async
- public func kickUser(userId: String,block: Bool? = nil)async throws -> KickUserResponse
+ public func disableClientCapabilities(_ capabilities: Set<ClientCapability>)async
+ public func kickUser(userId: String,block: Bool? = nil)async throws -> KickUserResponse |
Collaborator
SDK Size
|
Collaborator
StreamVideo XCSize
Show 97 more objects
|
Collaborator
StreamVideoSwiftUI XCSize
|
ipavlidakis
force-pushed
the
enhancement/hifi/feature-implementation
branch
from
ad2ecd8 to
ebfedd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Provide all JIRA tickets and/or GitHub issues related to this PR, if applicable.
🎯 Goal
Describe why we are making this change.
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
imgimg🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)