[V5] Remove controllerWillChangeChannels and cleanup willChange handling

[laevandus]

🔗 Issue Links

Resolves: IOS-1004

🎯 Goal

Remove controllerWillChangeChannels because it requires complicated handling on the DB observer level

📝 Summary

🛠 Implementation

🎨 Showcase

🧪 Manual Testing Notes

☑️ Contributor Checklist

• I have signed the Stream CLA (required)
• This change should be manually QAed
• Changelog is updated with client-facing changes
• Changelog is updated with new localization keys
• New code is covered by unit tests
• Documentation has been updated in the docs-content repo

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch v5-remove-controller-will-change

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

	1 Message
📖	There seems to be app changes but CHANGELOG wasn't modified. Please include an entry if the PR includes user-facing changes. You can find it at CHANGELOG.md.

Generated by 🚫 Danger

[Stream-SDK-Bot]

SDK Performance

target	metric	benchmark	branch	performance	status
MessageList	Hitches total duration	10 ms	6.68 ms	33.2% 🔼	🟢
	Duration	2.6 s	2.54 s	2.31% 🔼	🟢
	Hitch time ratio	4 ms per s	2.63 ms per s	34.25% 🔼	🟢
	Frame rate	75 fps	78.23 fps	4.31% 🔼	🟢
	Number of hitches	1	0.6	40.0% 🔼	🟢

[Stream-SDK-Bot]

SDK Size

title	develop	branch	diff	status
StreamChat	8.25 MB	7.98 MB	-277 KB	🚀
StreamChatUI	4.89 MB	5.05 MB	+162 KB	🟢

[martinmitrevski]

does this have any impact on the UI layer? Also, @nuno-vieira what do you think?

[github-actions]

Public Interface

 @available(iOSApplicationExtension, unavailable) open class ChatChannelListVC: _ViewController, UICollectionViewDataSource, UICollectionViewDelegate, ChatChannelListControllerDelegate, ThemeProvider, SwipeableViewDelegate  
-   open func controllerWillChangeChannels(_ controller: ChatChannelListController)
+   open func controller(_ controller: ChatChannelListController,didChangeChannels changes: [ListChange<ChatChannel>])
-   open func controller(_ controller: ChatChannelListController,didChangeChannels changes: [ListChange<ChatChannel>])
+   open func controller(_ controller: DataController,didChangeState state: DataController.State)
-   open func controller(_ controller: DataController,didChangeState state: DataController.State)
+   open func handleStateChanges(_ newState: DataController.State)
-   open func handleStateChanges(_ newState: DataController.State)

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE