Skip to content

Fix several optional typing issues #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix several optional typing issues #206

wants to merge 2 commits into from

Conversation

ngieseker
Copy link
Contributor

Submit a pull request

There's a few instances of the default being set as None but the typing not properly marked as optional to correctly set typing.

CLA

  • [ x] I have signed the Stream CLA (required).
  • [x ] The code changes follow best practices
  • [ x] Code changes are tested (add some information if not applicable)

Description of the pull request

@ngieseker ngieseker changed the title Fix optional typing issues across Fix several optional typing issues Sep 8, 2025
@ngieseker
Update channel.py
39181d9 
fix formatting?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@10printhello 10printhello Awaiting requested review from 10printhello 10printhello is a code owner

@totalimmersion totalimmersion Awaiting requested review from totalimmersion totalimmersion is a code owner

@slavabobik slavabobik Awaiting requested review from slavabobik slavabobik is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ngieseker